Skip to content

Commit 9a165c6

Browse files
committed
fix(integ): update add-remove-evaluator test to use --runtime flag
The integ test was still using --agent for online-eval commands, which was renamed to --runtime in the CLI flags rename commit. Also removes unused addOnlineEvalArgs variable.
1 parent ffd1bf0 commit 9a165c6

1 file changed

Lines changed: 4 additions & 18 deletions

File tree

integ-tests/add-remove-evaluator.test.ts

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -55,20 +55,6 @@ describe('integration: add and remove evaluators and online eval configs', () =>
5555
instructions,
5656
'--json',
5757
];
58-
const addOnlineEvalArgs = [
59-
'add',
60-
'online-eval',
61-
'--name',
62-
configName,
63-
'--agent',
64-
project?.agentName,
65-
'--evaluator',
66-
evalName,
67-
'--sampling-rate',
68-
'50',
69-
'--json',
70-
];
71-
7258
it('adds an evaluator', async () => {
7359
const json = await runSuccess(addEvalArgs, project.projectPath);
7460
expect(json.evaluatorName).toBe(evalName);
@@ -90,7 +76,7 @@ describe('integration: add and remove evaluators and online eval configs', () =>
9076
'online-eval',
9177
'--name',
9278
configName,
93-
'--agent',
79+
'--runtime',
9480
project.agentName,
9581
'--evaluator',
9682
evalName,
@@ -115,7 +101,7 @@ describe('integration: add and remove evaluators and online eval configs', () =>
115101
'online-eval',
116102
'--name',
117103
configName,
118-
'--agent',
104+
'--runtime',
119105
project.agentName,
120106
'--evaluator',
121107
evalName,
@@ -193,7 +179,7 @@ describe('integration: add and remove evaluators and online eval configs', () =>
193179

194180
it('rejects online eval with missing required flags', async () => {
195181
const json = await runFailure(['add', 'online-eval', '--name', 'SomeConfig', '--json'], project.projectPath);
196-
expect(json.error).toContain('--agent');
182+
expect(json.error).toContain('--runtime');
197183
});
198184

199185
it('rejects online eval with invalid sampling rate', async () => {
@@ -203,7 +189,7 @@ describe('integration: add and remove evaluators and online eval configs', () =>
203189
'online-eval',
204190
'--name',
205191
'SomeConfig',
206-
'--agent',
192+
'--runtime',
207193
project.agentName,
208194
'--evaluator',
209195
'SomeEval',

0 commit comments

Comments
 (0)