test: add useTextInput shortcut tests, fix guards mock, strengthen StepProgress

Author: notgitika

src/cli/tui/guards/__tests__/project.test.tsx

@@ -3,16 +3,18 @@ import { render } from 'ink-testing-library';
 import React from 'react';
 import { afterEach, describe, expect, it, vi } from 'vitest';
 
-const { mockFindConfigRoot } = vi.hoisted(() => ({
+const { mockFindConfigRoot, mockGetWorkingDirectory } = vi.hoisted(() => ({
   mockFindConfigRoot: vi.fn(),
+  mockGetWorkingDirectory: vi.fn(() => '/project'),
 }));
 
 vi.mock('../../../../lib/index.js', () => ({
   findConfigRoot: mockFindConfigRoot,
-  getWorkingDirectory: () => '/project',
-  NoProjectError: class extends Error {
-    constructor() {
-      super('No agentcore project found');
+  getWorkingDirectory: mockGetWorkingDirectory,
+  NoProjectError: class NoProjectError extends Error {
+    constructor(message = 'No agentcore project found') {
+      super(message);
+      this.name = 'NoProjectError';
     }
   },
 }));
@@ -39,6 +41,14 @@ describe('projectExists', () => {
 
     expect(mockFindConfigRoot).toHaveBeenCalledWith('/project');
   });
+
+  it('passes baseDir to findConfigRoot when provided', () => {
+    mockFindConfigRoot.mockReturnValue(null);
+
+    projectExists('/custom/path');
+
+    expect(mockFindConfigRoot).toHaveBeenCalledWith('/custom/path');
+  });
 });
 
 describe('getProjectRootMismatch', () => {
@@ -66,27 +76,34 @@ describe('getProjectRootMismatch', () => {
 });
 
 describe('MissingProjectMessage', () => {
-  it('renders with agentcore create for CLI mode', () => {
+  it('renders error message and "agentcore create" for CLI mode', () => {
     const { lastFrame } = render(<MissingProjectMessage />);
+    const frame = lastFrame()!;
 
-    expect(lastFrame()).toContain('No agentcore project found');
-    expect(lastFrame()).toContain('agentcore create');
+    expect(frame).toContain('No agentcore project found');
+    expect(frame).toContain('agentcore create');
   });
 
-  it('renders with create for TUI mode', () => {
+  it('renders "create" without "agentcore" prefix for TUI mode', () => {
     const { lastFrame } = render(<MissingProjectMessage inTui />);
-
-    expect(lastFrame()).toContain('No agentcore project found');
-    expect(lastFrame()).toContain('create');
+    const frame = lastFrame()!;
+
+    expect(frame).toContain('No agentcore project found');
+    expect(frame).toContain('create');
+    // In TUI mode, should NOT show the full CLI command
+    const lines = frame.split('\n');
+    const createLine = lines.find(l => l.includes('create'))!;
+    expect(createLine).not.toContain('agentcore create');
   });
 });
 
 describe('WrongDirectoryMessage', () => {
-  it('renders project root path', () => {
+  it('renders project root path with cd suggestion', () => {
     const { lastFrame } = render(<WrongDirectoryMessage projectRoot="/home/user/my-project" />);
+    const frame = lastFrame()!;
 
-    expect(lastFrame()).toContain('project root directory');
-    expect(lastFrame()).toContain('/home/user/my-project');
-    expect(lastFrame()).toContain('cd /home/user/my-project');
+    expect(frame).toContain('project root directory');
+    expect(frame).toContain('/home/user/my-project');
+    expect(frame).toContain('cd /home/user/my-project');
   });
 });

src/cli/tui/hooks/__tests__/useTextInput.test.tsx

@@ -7,6 +7,8 @@ import { afterEach, describe, expect, it, vi } from 'vitest';
 const ENTER = '\r';
 const ESCAPE = '\x1B';
 const BACKSPACE = '\x7f';
+const LEFT = '\x1B[D';
+const RIGHT = '\x1B[C';
 
 afterEach(() => vi.restoreAllMocks());
 
@@ -84,20 +86,38 @@ function TextInputHarness({
   onSubmit,
   onCancel,
   onChange,
+  onUpArrow,
+  onDownArrow,
+  isActive,
 }: {
   initialValue?: string;
   onSubmit?: (value: string) => void;
   onCancel?: () => void;
   onChange?: (value: string) => void;
+  onUpArrow?: () => void;
+  onDownArrow?: () => void;
+  isActive?: boolean;
 }) {
-  const { value, cursor } = useTextInput({ initialValue, onSubmit, onCancel, onChange });
+  const { value, cursor } = useTextInput({
+    initialValue,
+    onSubmit,
+    onCancel,
+    onChange,
+    onUpArrow,
+    onDownArrow,
+    isActive,
+  });
   return (
     <Text>
       val:[{value}] cur:{cursor}
     </Text>
   );
 }
 
+function delay(ms = 50) {
+  return new Promise(resolve => setTimeout(resolve, ms));
+}
+
 describe('useTextInput hook', () => {
   it('starts with initial value and cursor at end', () => {
     const { lastFrame } = render(<TextInputHarness initialValue="hello" />);
@@ -116,9 +136,9 @@ describe('useTextInput hook', () => {
   it('accepts character input', async () => {
     const { lastFrame, stdin } = render(<TextInputHarness />);
 
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
     stdin.write('a');
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
 
     expect(lastFrame()).toContain('val:[a]');
     expect(lastFrame()).toContain('cur:1');
@@ -127,10 +147,10 @@ describe('useTextInput hook', () => {
   it('accepts multiple characters', async () => {
     const { lastFrame, stdin } = render(<TextInputHarness />);
 
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
     stdin.write('h');
     stdin.write('i');
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
 
     expect(lastFrame()).toContain('val:[hi]');
     expect(lastFrame()).toContain('cur:2');
@@ -139,21 +159,32 @@ describe('useTextInput hook', () => {
   it('handles backspace', async () => {
     const { lastFrame, stdin } = render(<TextInputHarness initialValue="abc" />);
 
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
     stdin.write(BACKSPACE);
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
 
     expect(lastFrame()).toContain('val:[ab]');
     expect(lastFrame()).toContain('cur:2');
   });
 
-  it('calls onSubmit on Enter', async () => {
+  it('backspace at start does nothing', async () => {
+    const { lastFrame, stdin } = render(<TextInputHarness initialValue="" />);
+
+    await delay();
+    stdin.write(BACKSPACE);
+    await delay();
+
+    expect(lastFrame()).toContain('val:[]');
+    expect(lastFrame()).toContain('cur:0');
+  });
+
+  it('calls onSubmit on Enter with current text', async () => {
     const onSubmit = vi.fn();
     const { stdin } = render(<TextInputHarness initialValue="test" onSubmit={onSubmit} />);
 
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
     stdin.write(ENTER);
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
 
     expect(onSubmit).toHaveBeenCalledWith('test');
   });
@@ -162,19 +193,19 @@ describe('useTextInput hook', () => {
     const onCancel = vi.fn();
     const { stdin } = render(<TextInputHarness onCancel={onCancel} />);
 
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
     stdin.write(ESCAPE);
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
 
     expect(onCancel).toHaveBeenCalledTimes(1);
   });
 
   it('moves cursor left with arrow key', async () => {
     const { lastFrame, stdin } = render(<TextInputHarness initialValue="abc" />);
 
-    await new Promise(resolve => setTimeout(resolve, 50));
-    stdin.write('\x1B[D'); // left arrow
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
+    stdin.write(LEFT);
+    await delay();
 
     expect(lastFrame()).toContain('val:[abc]');
     expect(lastFrame()).toContain('cur:2');
@@ -183,29 +214,47 @@ describe('useTextInput hook', () => {
   it('moves cursor right with arrow key', async () => {
     const { lastFrame, stdin } = render(<TextInputHarness initialValue="abc" />);
 
-    // Move left first, then right
-    await new Promise(resolve => setTimeout(resolve, 50));
-    stdin.write('\x1B[D'); // left
-    stdin.write('\x1B[D'); // left
-    await new Promise(resolve => setTimeout(resolve, 50));
-
+    await delay();
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    await delay();
     expect(lastFrame()).toContain('cur:1');
 
-    stdin.write('\x1B[C'); // right arrow
-    await new Promise(resolve => setTimeout(resolve, 50));
+    stdin.write(RIGHT);
+    await delay();
+    expect(lastFrame()).toContain('cur:2');
+  });
+
+  it('cursor does not go below 0', async () => {
+    const { lastFrame, stdin } = render(<TextInputHarness initialValue="ab" />);
+
+    await delay();
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    stdin.write(LEFT); // try to go past 0
+    await delay();
+
+    expect(lastFrame()).toContain('cur:0');
+  });
+
+  it('cursor does not go past text length', async () => {
+    const { lastFrame, stdin } = render(<TextInputHarness initialValue="ab" />);
+
+    await delay();
+    stdin.write(RIGHT); // already at end (2)
+    await delay();
 
     expect(lastFrame()).toContain('cur:2');
   });
 
-  it('inserts character at cursor position', async () => {
+  it('inserts character at cursor position (middle of text)', async () => {
     const { lastFrame, stdin } = render(<TextInputHarness initialValue="ac" />);
 
-    // Move cursor left once (between a and c), then insert b
-    await new Promise(resolve => setTimeout(resolve, 50));
-    stdin.write('\x1B[D'); // left, cursor now at 1
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
+    stdin.write(LEFT); // cursor at 1
+    await delay();
     stdin.write('b');
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
 
     expect(lastFrame()).toContain('val:[abc]');
     expect(lastFrame()).toContain('cur:2');
@@ -215,10 +264,106 @@ describe('useTextInput hook', () => {
     const onChange = vi.fn();
     const { stdin } = render(<TextInputHarness onChange={onChange} />);
 
-    await new Promise(resolve => setTimeout(resolve, 50));
+    await delay();
     stdin.write('x');
-    await new Promise(resolve => setTimeout(resolve, 100));
+    await delay(100);
 
     expect(onChange).toHaveBeenCalledWith('x');
   });
+
+  it('calls onUpArrow on up arrow key', async () => {
+    const onUpArrow = vi.fn();
+    const { stdin } = render(<TextInputHarness onUpArrow={onUpArrow} />);
+
+    await delay();
+    stdin.write('\x1B[A'); // up arrow
+    await delay();
+
+    expect(onUpArrow).toHaveBeenCalledTimes(1);
+  });
+
+  it('calls onDownArrow on down arrow key', async () => {
+    const onDownArrow = vi.fn();
+    const { stdin } = render(<TextInputHarness onDownArrow={onDownArrow} />);
+
+    await delay();
+    stdin.write('\x1B[B'); // down arrow
+    await delay();
+
+    expect(onDownArrow).toHaveBeenCalledTimes(1);
+  });
+});
+
+describe('useTextInput keyboard shortcuts', () => {
+  it('Ctrl+A moves cursor to start', async () => {
+    const { lastFrame, stdin } = render(<TextInputHarness initialValue="hello world" />);
+
+    await delay();
+    stdin.write('\x01'); // Ctrl+A
+    await delay();
+
+    expect(lastFrame()).toContain('val:[hello world]');
+    expect(lastFrame()).toContain('cur:0');
+  });
+
+  it('Ctrl+E moves cursor to end', async () => {
+    const { lastFrame, stdin } = render(<TextInputHarness initialValue="hello world" />);
+
+    // Move to start first, then Ctrl+E
+    await delay();
+    stdin.write('\x01'); // Ctrl+A → cursor:0
+    await delay();
+    stdin.write('\x05'); // Ctrl+E
+    await delay();
+
+    expect(lastFrame()).toContain('cur:11');
+  });
+
+  it('Ctrl+W deletes previous word', async () => {
+    const { lastFrame, stdin } = render(<TextInputHarness initialValue="hello world" />);
+
+    await delay();
+    stdin.write('\x17'); // Ctrl+W
+    await delay();
+
+    expect(lastFrame()).toContain('val:[hello ]');
+    expect(lastFrame()).toContain('cur:6');
+  });
+
+  it('Ctrl+U deletes from cursor to start', async () => {
+    const { lastFrame, stdin } = render(<TextInputHarness initialValue="hello world" />);
+
+    // Move cursor to middle first
+    await delay();
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    stdin.write(LEFT); // cursor at 6
+    await delay();
+    stdin.write('\x15'); // Ctrl+U
+    await delay();
+
+    expect(lastFrame()).toContain('val:[world]');
+    expect(lastFrame()).toContain('cur:0');
+  });
+
+  it('Ctrl+K deletes from cursor to end', async () => {
+    const { lastFrame, stdin } = render(<TextInputHarness initialValue="hello world" />);
+
+    // Move cursor to position 5
+    await delay();
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    stdin.write(LEFT);
+    stdin.write(LEFT); // cursor at 5
+    await delay();
+    stdin.write('\x0B'); // Ctrl+K
+    await delay();
+
+    expect(lastFrame()).toContain('val:[hello]');
+    expect(lastFrame()).toContain('cur:5');
+  });
 });