fix(tui-tests): address PR review feedback

- Drop waitFor timeout for menu filter from 3s to 1.5s to catch
  performance regressions (filter echo should be near-instant)
- Fail hard in CI when TUI harness is unavailable instead of silently
  skipping, preventing false-green CI runs
- Bump create wizard completion timeout from 30s to 60s (CDK
  scaffolding regularly takes >30s under load)

Author: aidandaly24

integ-tests/tui/add-flow.test.ts

@@ -44,7 +44,7 @@ describe.skipIf(!isAvailable)('TUI add-resource flow', () => {
 
     // Type 'add' to filter the command list, then press Enter to select it.
     await session.sendKeys('add');
-    await session.waitFor('add', 3000);
+    await session.waitFor('add', 1500);
     await session.sendSpecialKey('enter');
 
     // Confirm the Add Resource screen has rendered.
@@ -73,7 +73,7 @@ describe.skipIf(!isAvailable)('TUI add-resource flow', () => {
 
     // Navigate to Add Resource screen.
     await session.sendKeys('add');
-    await session.waitFor('add', 3000);
+    await session.waitFor('add', 1500);
     await session.sendSpecialKey('enter');
     await session.waitFor('Add Resource', 10000);
 
@@ -106,7 +106,7 @@ describe.skipIf(!isAvailable)('TUI add-resource flow', () => {
 
     // Navigate: HelpScreen -> Add Resource -> Add Agent
     await session.sendKeys('add');
-    await session.waitFor('add', 3000);
+    await session.waitFor('add', 1500);
     await session.sendSpecialKey('enter');
     await session.waitFor('Add Resource', 10000);
     await session.sendSpecialKey('enter');
@@ -137,7 +137,7 @@ describe.skipIf(!isAvailable)('TUI add-resource flow', () => {
 
     // Navigate to Add Resource screen.
     await session.sendKeys('add');
-    await session.waitFor('add', 3000);
+    await session.waitFor('add', 1500);
     await session.sendSpecialKey('enter');
     await session.waitFor('Add Resource', 10000);
 

integ-tests/tui/create-flow.test.ts

@@ -132,8 +132,9 @@ describe.skipIf(!isAvailable)('create wizard TUI flow', () => {
     await session.waitFor('Review Configuration', 10000);
     await session.sendSpecialKey('enter');
 
-    // Step 21: Wait for project creation to complete (generous timeout)
-    const successScreen = await session.waitFor('Project created successfully', 30000);
+    // Step 21: Wait for project creation to complete (generous timeout —
+    // CDK scaffolding + git init can take >30s under load)
+    const successScreen = await session.waitFor('Project created successfully', 60000);
 
     const successText = successScreen.lines.join('\n');
     expect(successText).toContain('Project created successfully');
@@ -174,7 +175,7 @@ describe.skipIf(!isAvailable)('create wizard TUI flow', () => {
     await session.sendSpecialKey('enter');
 
     // Wait for project creation to complete
-    const successScreen = await session.waitFor('Project created successfully', 30000);
+    const successScreen = await session.waitFor('Project created successfully', 60000);
 
     const successText = successScreen.lines.join('\n');
     expect(successText).toContain('Project created successfully');

integ-tests/tui/setup.ts

@@ -7,9 +7,15 @@ beforeAll(async () => {
   try {
     const { isAvailable, unavailableReason } = await import('../../src/tui-harness/lib/availability.js');
     if (!isAvailable) {
+      if (process.env.CI) {
+        throw new Error(`TUI harness unavailable in CI: ${unavailableReason}. Failing to prevent silent skip.`);
+      }
       console.warn(`TUI harness unavailable: ${unavailableReason}. Skipping all TUI tests.`);
     }
-  } catch {
+  } catch (err) {
+    if (err instanceof Error && err.message.startsWith('TUI harness unavailable in CI')) {
+      throw err;
+    }
     // Harness not yet built
   }
 });