fix: enrich dev logs with connection retry details and full stack traces#181
Conversation
aidandaly24
left a comment
There was a problem hiding this comment.
looks good to me i like this
|
Reviewed post-merge — changes look good overall. The logging enrichment is minimal, focused, and the interface extension ( A couple of non-blocking observations for future follow-up:
None of these are blockers; the PR is fine as merged. |
…ows (#181) Use actions/create-github-app-token@v1 to generate a short-lived token for cloning the CDK repo instead of the CDK_REPO_TOKEN PAT secret.
Fixes #137
Description
Enrich dev logs with detailed connection retry info and full error stack traces.
Changes:
SSELoggerinterface with optionallog()methodInvokeOptionsinterface for logger support (backwards compatible)Example log output:
[12:34:56] [WARN] Connection failed (attempt 1/5): ECONNREFUSED. Retrying in 500ms...
[12:34:58] [ERROR] Failed to connect after 5 attempts: Error: ECONNREFUSED
at fetch (...)
at invokeAgent (...)
Related Issues
#137
Documentation PR
Type of Change
Testing
How have you tested the change?
npm run test:allnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.