Skip to content

fix(deploy): restore stack selection strategy for deploy and diff #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tejaskash merged 1 commit into from
May 13, 2026
Merged

fix(deploy): restore stack selection strategy for deploy and diff #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/cli/commands/deploy/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ import {
} from '../../operations/deploy/post-deploy-config-bundles';
import { setupHttpGateways } from '../../operations/deploy/post-deploy-http-gateways';
import { enableOnlineEvalConfigs } from '../../operations/deploy/post-deploy-online-evals';
import { toStackName } from '../import/import-utils';
import type { DeployResult } from './types';
import { StackSelectionStrategy } from '@aws-cdk/toolkit-lib';

export interface ValidatedDeployOptions {
target: string;
Expand Down Expand Up @@ -248,7 +250,13 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
logger.finalize(false);
return { success: false, error: 'No stacks found to deploy', logPath: logger.getRelativeLogPath() };
}
const stackName = stackNames[0]!;
const targetStackName = toStackName(context.projectSpec.name, target.name);
Comment thread
notgitika marked this conversation as resolved.
if (!stackNames.includes(targetStackName)) {
endStep('error', `Stack "${targetStackName}" not found in synthesized stacks`);
logger.finalize(false);
return { success: false, error: `Stack "${targetStackName}" not found`, logPath: logger.getRelativeLogPath() };
}
const stackName = targetStackName;
endStep('success');

// Check if bootstrap needed
Expand All @@ -272,7 +280,7 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

// Check stack deployability
startStep('Check stack status');
const deployabilityCheck = await checkStackDeployability(target.region, stackNames);
const deployabilityCheck = await checkStackDeployability(target.region, [stackName]);
if (!deployabilityCheck.canDeploy) {
endStep('error', deployabilityCheck.message);
logger.finalize(false);
Expand Down Expand Up @@ -311,7 +319,9 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
}
});
diffIoHost.setVerbose(true);
await toolkitWrapper.diff();
await toolkitWrapper.diff({
stacks: { strategy: StackSelectionStrategy.PATTERN_MUST_MATCH, patterns: [targetStackName] },
});
if (!hasDiffContent) {
console.log('No stack differences detected.');
}
Expand Down Expand Up @@ -349,7 +359,9 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
switchableIoHost.setVerbose(true);
}

await toolkitWrapper.deploy();
await toolkitWrapper.deploy({
stacks: { strategy: StackSelectionStrategy.PATTERN_MUST_MATCH, patterns: [targetStackName] },
});

// Disable verbose output
if (switchableIoHost) {
Expand Down
Loading