Skip to content

test(security-review): verify /security-review path against fix-fork-secrets#1318

Closed
tejaskash wants to merge 2 commits into
fix-fork-secretsfrom
sec-review-test-against-fix
Closed

test(security-review): verify /security-review path against fix-fork-secrets#1318
tejaskash wants to merge 2 commits into
fix-fork-secretsfrom
sec-review-test-against-fix

Conversation

@tejaskash

Copy link
Copy Markdown
Contributor

Throwaway PR for testing — do not merge, do not review.

Base = fix-fork-secrets (PR #1310's branch) so the security review workflow that runs on this PR is the new one with bundled-slash-command + honest summary + cancel-in-progress=false. Verifies the inline-comment posting path before #1310 merges.

The diff adds a single file with two deliberate findings the bundled /security-review skill should flag (hardcoded AWS creds + command injection via exec).

Will close once verified.

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 20, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 20, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 20, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Per the PR description, this is a throwaway smoke-test PR not intended to be reviewed or merged — skipping a substantive code review.

One meta-observation since I'm here: the bundled /security-review run on this PR posted "no high-confidence findings" (run), even though scripts/__sec_review_smoketest.mjs contains two deliberate HIGH-severity issues (hardcoded AWS credential pattern + exec() command injection from an unvalidated HTTP query param). That's the opposite of what this PR was designed to verify — worth confirming whether the skill is correctly skipping AWS example credentials / test fixtures (in which case the smoketest needs more realistic-looking findings), or whether the inline-comment posting path is silently failing. Either way, the verification goal of this PR doesn't appear to have been met yet.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 20, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 20, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 20, 2026
@tejaskash

Copy link
Copy Markdown
Contributor Author

Closing — base-branch testing strategy doesn't work for pull_request_target (workflow always reads from default branch). Will verify the fixes in #1310 on a real PR after that merges.

@tejaskash tejaskash closed this May 20, 2026
@tejaskash tejaskash deleted the sec-review-test-against-fix branch May 21, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants