Skip to content

Reapply "feat: add support for LTM metadata (#1281)" (#1338)#1346

Merged
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:feat/enable-ltm-metadata
May 21, 2026
Merged

Reapply "feat: add support for LTM metadata (#1281)" (#1338)#1346
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:feat/enable-ltm-metadata

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

This reverts commit 2d8b9d7.

original PR was approved.

I've manually tested some basic flows with the assumption @nborges-aws has done deeper testing + planned bug bashing later.

@github-actions github-actions Bot added the size/xl PR size: XL label May 21, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.14.2.tgz

How to install

gh release download pr-1346-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz

@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean reapply of #1281 — I verified the per-file diffs of the 15 source/doc files in this PR are byte-identical (in their +/- lines) to commit 44b5c2c (the original feature commit), so all the fixes from the original PR review (useEffect-based rehydration of indexed-key state, shared validateIndexedKeyName/constants between schema and TUI, indexed_key_count / has_indexed_keys telemetry on both MemoryPrimitive and useCreateMemory, key-name persistence on Esc-back from the type substep) are preserved.

The schema also still slots in cleanly against the post-revert mainline — MemorySchema and the IndexedKey* constants/regex live in agentcore-project.ts, and the new primitives/memory.ts only owns MemoryStrategy*, so there's no overlap or drift with the namespace-templates refactor that landed while this was reverted.

One blocker I want to flag before merge:

validate-pr-title is failing. The current title Reapply "feat: add support for LTM metadata (#1281)" (#1338) doesn't start with a conventional-commit type, and the amannn/action-semantic-pull-request check rejects it (failing run). Options:

  • Retitle to e.g. feat: re-add support for LTM metadata (reapply #1281) (or similar — feat/fix/chore/revert are all accepted).
  • Or apply the bot label, which the workflow's ignoreLabels config skips.

Otherwise looks good to merge.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 21, 2026
@Hweinstock Hweinstock marked this pull request as ready for review May 21, 2026 16:31
@Hweinstock Hweinstock requested a review from a team May 21, 2026 16:31
@Hweinstock Hweinstock merged commit 2091322 into aws:main May 21, 2026
27 of 28 checks passed
@Hweinstock Hweinstock deleted the feat/enable-ltm-metadata branch May 21, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants