Skip to content

fix: add -g flag to bundle install instructions#1348

Merged
jesseturner21 merged 1 commit into
aws:mainfrom
Hweinstock:fix/bundle-global-install
May 21, 2026
Merged

fix: add -g flag to bundle install instructions#1348
jesseturner21 merged 1 commit into
aws:mainfrom
Hweinstock:fix/bundle-global-install

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

Description

The bundle script outputs an npm install <tarball> instruction after building, but without -g the CLI binary is not linked globally and the agentcore command is not available. This adds the -g flag to the install instruction.

Related Issue

N/A

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/xl PR size: XL label May 21, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 21, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@Hweinstock Hweinstock force-pushed the fix/bundle-global-install branch from a4ebbc4 to de8ca3e Compare May 21, 2026 17:01
@github-actions github-actions Bot added size/xs PR size: XS and removed size/xl PR size: XL labels May 21, 2026
Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. The change correctly aligns the printed install instruction with the intended global install (matches the documented usage npm install -g <path-to-tar> for testing the CLI end-to-end). Single-line, low-risk fix; no tests or telemetry needed.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.14.2.tgz

How to install

gh release download pr-1348-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz

@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels May 21, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@Hweinstock Hweinstock marked this pull request as ready for review May 21, 2026 17:08
@Hweinstock Hweinstock requested a review from a team May 21, 2026 17:08
@jesseturner21 jesseturner21 merged commit 4adc9c0 into aws:main May 21, 2026
25 checks passed
@Hweinstock Hweinstock deleted the fix/bundle-global-install branch May 21, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants