ci: add preview tarball workflow#1349
Open
Hweinstock wants to merge 4 commits into
Open
Conversation
Contributor
Package TarballHow to installgh release download pr-1349-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-cli-automation
suggested changes
May 21, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Workflow looks reasonable overall, but there are a few things that should be sorted out before merging. Main concerns:
- The workflow depends on a GitHub App (
vars.APP_ID/secrets.APP_PRIVATE_KEY) that no other workflow in the repo references — if those aren't configured at the repo/org level, every run onmainwill fail. It's also unclear why an App token is needed whenpr-tarball.ymluses the default${{ github.token }}for the samegh release createflow. - The delete-then-recreate sequence for the
prereleasetag opens a multi-minute window where the download URL 404s for users (the upload of the bundled tarball isn't trivial). Worth usinggh release upload --clobberto swap the asset on an existing release instead. - The Node version (22.x) doesn't match the 20.x used by
pr-tarball.ymland the main job inrelease.yml, so the prerelease tarball won't be built/packed under the same Node as the official release.
None of these are deep changes — leaving inline comments with specifics.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a GitHub Actions workflow that builds and publishes a prerelease tarball (with bundled CDK constructs) on every push to main. The release is tagged
prereleaseand updated in-place. Also supportsworkflow_dispatchfor manually pulling in latest CDK changes.Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsWorkflow-only change — validated YAML syntax locally.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.