Skip to content

ci: add preview tarball workflow#1349

Open
Hweinstock wants to merge 4 commits into
aws:mainfrom
Hweinstock:feat/preview-tarball
Open

ci: add preview tarball workflow#1349
Hweinstock wants to merge 4 commits into
aws:mainfrom
Hweinstock:feat/preview-tarball

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

Description

Add a GitHub Actions workflow that builds and publishes a prerelease tarball (with bundled CDK constructs) on every push to main. The release is tagged prerelease and updated in-place. Also supports workflow_dispatch for manually pulling in latest CDK changes.

Related Issue

N/A

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Workflow-only change — validated YAML syntax locally.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress labels May 21, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.14.2.tgz

How to install

gh release download pr-1349-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz

@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow looks reasonable overall, but there are a few things that should be sorted out before merging. Main concerns:

  1. The workflow depends on a GitHub App (vars.APP_ID / secrets.APP_PRIVATE_KEY) that no other workflow in the repo references — if those aren't configured at the repo/org level, every run on main will fail. It's also unclear why an App token is needed when pr-tarball.yml uses the default ${{ github.token }} for the same gh release create flow.
  2. The delete-then-recreate sequence for the prerelease tag opens a multi-minute window where the download URL 404s for users (the upload of the bundled tarball isn't trivial). Worth using gh release upload --clobber to swap the asset on an existing release instead.
  3. The Node version (22.x) doesn't match the 20.x used by pr-tarball.yml and the main job in release.yml, so the prerelease tarball won't be built/packed under the same Node as the official release.

None of these are deep changes — leaving inline comments with specifics.

Comment thread .github/workflows/preview-tarball.yml Outdated
Comment thread .github/workflows/preview-tarball.yml Outdated
Comment thread .github/workflows/prerelease-tarball.yml
@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 21, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels May 21, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels May 21, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@Hweinstock Hweinstock marked this pull request as ready for review May 21, 2026 21:15
@Hweinstock Hweinstock requested a review from a team May 21, 2026 21:15
@github-actions github-actions Bot removed the size/s PR size: S label May 21, 2026
@Hweinstock Hweinstock deployed to e2e-testing May 21, 2026 21:19 — with GitHub Actions Active
@github-actions github-actions Bot added the size/s PR size: S label May 21, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants