fix: initialize telemetry for full-screen TUI mode#1350
Draft
Hweinstock wants to merge 1 commit into
Draft
Conversation
TelemetryClientAccessor.init() was never called when launching the full-screen TUI (agentcore with no args). The client fell back to lazy init with mode='cli' and no shutdown() was ever called, so metrics were either misattributed or lost when the process exited.
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1350-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-cli-automation
approved these changes
May 21, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Looks good — small, targeted fix that correctly addresses both stated issues:
TelemetryClientAccessor.init('tui', 'tui')is now called beforerenderTUI(), so the bare-agentcoreinvocation gets tagged withmode=tuiinstead of falling back to the lazymode=clidefault.TelemetryClientAccessor.shutdown()is now invoked from thewaitUntilExit().then(...)handler, so the OTLP exporter gets a chance to flush buffered metrics before process exit.
I verified the init signature (init(entrypoint, mode)) — both args being 'tui' is correct. Ink's default Ctrl+C handling unmounts cleanly and resolves waitUntilExit(), so the new shutdown() also runs on the common Ctrl+C-from-TUI exit path. Browser-dev exit action doesn't emit telemetry, so calling shutdown() before launchBrowserDev() is fine for now.
No new issues worth blocking on.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
Hweinstock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When launching the full-screen TUI via bare
agentcore(no args),TelemetryClientAccessor.init()was never called. Theargs.length === 0branch returned before reaching theinit()call that serves the CLI path. This meant:mode="cli"instead ofmode="tui"TelemetryClientAccessor.shutdown()was never called, so the OTLP exporter could lose buffered metrics on process exitThis PR adds
init("tui", "tui")beforerenderTUI()andshutdown()in thewaitUntilExit()handler.Related Issue
Closes #
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.