-
Notifications
You must be signed in to change notification settings - Fork 41
fix: create global entrypoint for tui #1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hweinstock
wants to merge
9
commits into
aws:main
Choose a base branch
from
Hweinstock:fix/tui-telemetry-init
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d4e050e
fix: create global entrypoint for tui
Hweinstock 64d6720
fix: emit cli.command_run telemetry for TUI invoke sessions
Hweinstock d20931d
fix: thread isInteractive through renderTUI to preserve auto-exit beh…
Hweinstock ed75a39
fix: prevent double telemetry client init on command-routed TUI paths
Hweinstock e1045f0
refactor: simplify renderTUI by awaiting waitUntilExit directly
Hweinstock 8d0f3b3
refactor: extract renderTUI into src/cli/tui/render-tui.ts
Hweinstock d4efe1d
fix: thread diffMode through deploy route to DeployScreen
Hweinstock 8acb65f
fix: resolve agent_protocol from project spec in invoke telemetry
Hweinstock 7f6cf1a
docs: clarify InitialRoute exclusion comment
Hweinstock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,17 @@ | ||
| import { type Result, ValidationError, serializeResult } from '../../../lib'; | ||
| import { ValidationError, serializeResult } from '../../../lib'; | ||
| import { getErrorMessage } from '../../errors'; | ||
| import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js'; | ||
| import { AgentProtocol, AuthType, standardize } from '../../telemetry/schemas/common-shapes.js'; | ||
| import { renderTUI } from '../../tui'; | ||
| import { COMMAND_DESCRIPTIONS } from '../../tui/copy'; | ||
| import { requireProject, requireTTY } from '../../tui/guards'; | ||
| import { InvokeScreen } from '../../tui/screens/invoke'; | ||
| import { parseHeaderFlags } from '../shared/header-utils'; | ||
| import { type InvokeContext, handleInvoke, loadInvokeConfig } from './action'; | ||
| import { resolvePrompt } from './resolve-prompt'; | ||
| import type { InvokeOptions, InvokeResult } from './types'; | ||
| import { validateInvokeOptions } from './validate'; | ||
| import type { Command } from '@commander-js/extra-typings'; | ||
| import { Text, render } from 'ink'; | ||
| import React from 'react'; | ||
|
|
||
| const SPINNER_FRAMES = ['⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏']; | ||
|
|
||
|
|
@@ -241,33 +240,18 @@ export const registerInvoke = (program: Command) => { | |
| headers = parseHeaderFlags(cliOptions.header); | ||
| } | ||
|
|
||
| const tuiResult = await withCommandRunTelemetry( | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. telemetry is moved inside the invoke logic since the client is now initialized in renderTUI. |
||
| 'invoke', | ||
| { | ||
| has_stream: true, | ||
| has_session_id: !!cliOptions.sessionId, | ||
| auth_type: standardize(AuthType, cliOptions.bearerToken ? 'bearer_token' : 'sigv4'), | ||
| agent_protocol: standardize(AgentProtocol, resolveProtocol({}, agentProtocol)), | ||
| await renderTUI({ | ||
| initialRoute: { | ||
| name: 'invoke', | ||
| sessionId: cliOptions.sessionId, | ||
| userId: cliOptions.userId, | ||
| headers, | ||
| bearerToken: cliOptions.bearerToken, | ||
| }, | ||
| async (): Promise<Result> => { | ||
| const { waitUntilExit, unmount } = render( | ||
| <InvokeScreen | ||
| isInteractive={true} | ||
| onExit={() => unmount()} | ||
| initialSessionId={cliOptions.sessionId} | ||
| initialUserId={cliOptions.userId} | ||
| initialHeaders={headers} | ||
| initialBearerToken={cliOptions.bearerToken} | ||
| /> | ||
| ); | ||
| await waitUntilExit(); | ||
| return { success: true }; | ||
| } | ||
| ); | ||
| if (!tuiResult.success) { | ||
| render(<Text color="red">Error: {getErrorMessage(tuiResult.error)}</Text>); | ||
| process.exit(1); | ||
| } | ||
| enterAltScreen: false, | ||
| actionOnBack: 'exit', | ||
| isInteractive: false, | ||
| }); | ||
|
Hweinstock marked this conversation as resolved.
|
||
| } | ||
| } catch (error) { | ||
| if (cliOptions.json) { | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field is dropped because it wasn't actually used: https://github.com/aws/agentcore-cli/blob/4adc9c08/src/cli/commands/deploy/command.tsx#L211-L214