Closed
Conversation
Add VPC configuration steps (network mode, subnets, security groups) to both the Create (template-based) and BYO (bring your own code) TUI wizards. When VPC mode is selected, the Exa AI MCP client is excluded from generated agent code and the mcp_client/ directory is not rendered, since VPC agents may not have public internet access. VPC warnings are shown in the dev and invoke TUI screens.
tejaskash
had a problem deploying
to
e2e-testing
GitHub Actions
Failure
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| from autogen_core.tools import FunctionTool | ||
| from bedrock_agentcore.runtime import BedrockAgentCoreApp | ||
| from model.load import load_model | ||
| {{#unless isVpc}} |
| from agents import Agent, Runner, function_tool | ||
| from bedrock_agentcore.runtime import BedrockAgentCoreApp | ||
| from model.load import load_model | ||
| {{#unless isVpc}} |
| from langchain.tools import tool | ||
| from bedrock_agentcore.runtime import BedrockAgentCoreApp | ||
| from model.load import load_model | ||
| {{#unless isVpc}} |
Contributor
Coverage Report
|
Contributor
Author
|
Splitting into two PRs: template changes and TUI changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_client/directory when VPC mode is selected, since VPC agents may lack public internet accessTest plan
npm run build— TypeScript compilesnpm test— all 1776 tests passnpm run lint— no lint errorsmain.pyfor all frameworks (Strands, LangChain/LangGraph, GoogleADK, OpenAI Agents) excludes MCP client in VPC mode and includes it in PUBLIC modemcp_client/directory is not rendered for VPC projectsagentcore.jsoncontains correctnetworkModeandnetworkConfigfieldsagentcore create→ walk through wizard → verify VPC steps appear, validation works, PUBLIC skips subnet/SG steps, confirm shows VPC infoagentcore add agent --type byo→ verify VPC steps in BYO path