feat: add TUI wizard streaming steps and docs for memory record streaming#534
Draft
Hweinstock wants to merge 5 commits intoaws:mainfrom
Draft
feat: add TUI wizard streaming steps and docs for memory record streaming#534Hweinstock wants to merge 5 commits intoaws:mainfrom
Hweinstock wants to merge 5 commits intoaws:mainfrom
Conversation
…or memory record streaming
- Replace unsafe `as MemoryStrategyType` casts with Zod parse - Include deliveryType in streamDeliveryResources conflict check - Reject deliveryType without dataStreamArn - Validate streamDeliveryResources JSON eagerly in validator - Include Zod error details in parseStreamDeliveryResources - Extract DEFAULT_DELIVERY_TYPE constant - Tighten createMemory strategies param type
CUSTOM is not a valid MemoryStrategyType. The previous test relied on an unsafe `as` cast to pass an invalid strategy through. Now that we use Zod parse, invalid strategies are correctly rejected.
4914e31 to
fb537db
Compare
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-534-tarball/aws-agentcore-0.6.0.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
The interactive TUI wizard for
agentcore add memorydoes not support configuring memory record streaming.Solution
Added streaming steps to the TUI wizard: enable yes/no → delivery target ARN → content level select. Updated useCreateMemory hook to pass streaming config through to the primitive. Added TUI wizard instructions to
docs/memory.md.
Builds on #531.
Related Issue
Closes #528
Type of Change
Testing
How have you tested the change?
Tested manually running the TUI locally.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.