Skip to content

feat: add managedBy enum field to AgentCoreProjectSpec schema#700

Merged
notgitika merged 14 commits intoaws:mainfrom
notgitika:feat/managed-by
Mar 27, 2026
Merged

feat: add managedBy enum field to AgentCoreProjectSpec schema#700
notgitika merged 14 commits intoaws:mainfrom
notgitika:feat/managed-by

Conversation

@notgitika
Copy link
Copy Markdown
Contributor

@notgitika notgitika commented Mar 27, 2026

Description

Adds a top-level managedBy enum field to AgentCoreProjectSpecSchema. This field tracks which tool manages the project infrastructure (currently only CDK). Defined as z.enum(['CDK']).default('CDK') for backwards compatibility — existing agentcore.json files without the field parse correctly with the default value applied.

Changes:

  • Add ManagedBySchema and ManagedBy type export to schema
  • Add managedBy field to AgentCoreProjectSpecSchema after version
  • Update all construction sites and test fixtures
  • Update LLM-compacted schema
  • Update snapshots

Related Issue

Closes #

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Additional testing:

  • Verified backwards compatibility against existing test project in agentcore/testing/ (no managedBy field parses with default CDK)
  • Added 3 schema validation tests: default applied when omitted, explicit CDK accepted, invalid values rejected

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Note: CDK package has matching schema change in a separate PR against agentcore-l3-cdk-constructs.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@notgitika notgitika requested a review from a team March 27, 2026 14:26
@github-actions github-actions Bot added the size/m PR size: M label Mar 27, 2026
@github-actions github-actions Bot added size/m PR size: M and removed size/m PR size: M labels Mar 27, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/m PR size: M labels Mar 27, 2026
tejaskash
tejaskash previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Contributor

@aidandaly24 aidandaly24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm approved

@notgitika notgitika merged commit c123d2f into aws:main Mar 27, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants