fix(e2e): use --runtime flag instead of --agent in byo-custom-jwt tests#795
Merged
aidandaly24 merged 1 commit intomainfrom Apr 9, 2026
Merged
fix(e2e): use --runtime flag instead of --agent in byo-custom-jwt tests#795aidandaly24 merged 1 commit intomainfrom
aidandaly24 merged 1 commit intomainfrom
Conversation
…ustom-jwt tests PR #749 introduced MCP bearer-token E2E tests that pass --agent to the invoke command, but the CLI defines --runtime for selecting a specific runtime. This caused the "MCP agent: rejects SigV4 invocation" test to fail on main with "error: unknown option '--agent'". The other new tests passed by accident because their assertions checked for the absence of an auth error, and a CLI parsing error also doesn't match that pattern.
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-795-tarball/aws-agentcore-0.7.1.tgz |
Contributor
Coverage Report
|
vivdalal
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #749 introduced MCP bearer-token E2E tests in
byo-custom-jwt.test.tsthat pass--agentto theinvokecommand, but the CLI defines--runtimefor selecting a specific runtime (seesrc/cli/commands/invoke/command.tsx). This causes the"MCP agent: rejects SigV4 invocation"test to fail on main witherror: unknown option '--agent'.The other three new tests passed by accident because their assertions check for the absence of an auth error pattern, and a CLI parsing error also doesn't match that pattern — so the bug was masked.
This PR replaces all four
--agentoccurrences with--runtimein the E2E test.Related Issue
Follow-up fix for #749
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.