refactor: consolidate cli-config into global-config#802
Open
Hweinstock wants to merge 1 commit intoaws:mainfrom
Open
refactor: consolidate cli-config into global-config#802Hweinstock wants to merge 1 commit intoaws:mainfrom
Hweinstock wants to merge 1 commit intoaws:mainfrom
Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-802-tarball/aws-agentcore-0.7.1.tgz |
fb1cb6d to
ce11738
Compare
ce11738 to
17ed5c8
Compare
17ed5c8 to
39c6bc8
Compare
avi-alpert
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cli-config.tsandglobal-config.tsboth read/write~/.agentcore/config.jsonwith separate schemas and I/O. This consolidates them into a single owner (global-config.ts) with a Zod schema covering all fields.global-config.tstosrc/lib/schemas/io/readGlobalConfigSyncfor callers that want sync reads (build-args.ts,post-deploy-observability.ts)readCliConfigtoreadGlobalConfigSynccli-config.tsreadGlobalConfigSyncRelated Issue
Follow-up to #797
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsVerified:
readGlobalConfigSynccovers happy path (parsed config) and error paths (missing file, malformed JSON). Post-deploy-observability tests pass with updated mock target. Zero remaining references toreadCliConfigorcli-config.ts.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.