Fix dbi ipv6 localhost#2192
Open
Paamicky wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
When customers configure Database Insights with an IPv6 loopback endpoint ([::1]:5432), the isLocalhostEndpoint function does not recognize the bracketed IPv6 format as a local address. This causes the agent to attempt an SSL connection to localhost, which fails with pq: SSL is not enabled on the server when PostgreSQL does not have SSL configured.
Description of changes
Added
[::1]to theisLocalhostEndpointcheck in the DBI translator. This ensures IPv6 loopback addresses in the standard bracket notation are correctly identified as localhost.Agent config
Tests
TestIsLocalhostEndpointwith [::1]:5432 test case[::1]:5432, confirmed the agent connects to PostgreSQL over IPv6 without SSL errors and scrapes metrics successfullyLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.