Add windows events logs for opentelemetry section#2193
Open
jefchien wants to merge 3 commits into
Open
Conversation
3449f76 to
da1af20
Compare
0fd006d to
a54956f
Compare
a54956f to
bea91f6
Compare
bea91f6 to
c4ac8b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
opentelemetry.collect.windows_eventswith:windowseventlogreceiver[a-z0-9-])event_ids+event_format: "xml"is rejected at translation time (OTTL body filter can't work on raw XML)windowseventlogreceiveris bumped past v0.124 to include Query XML support for native channel-level filtering, can swap out thefilterprocessorwith aquery(https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.150.0/receiver/windowseventlogreceiver/README.md#xml-queries) similar tologs/logs_collected/windows_events.aws.log.source,aws.log.channel)/aws/cwagent/windows_events{host.id}/{channel}default:otelincludes System + Application on Windows)cloudwatch.solution: "otel-windows-events")filterprocessor.NewTranslatorWithLogConditionto accept an error mode parameter (was DBI-only, now shared with windows_events).Unsupported fields compared to
logs/logs_collected/windows_eventsfilters(regex-based include/exclude filtering)log_group_class(STANDARD/INFREQUENT_ACCESS)retention_in_daysLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
windows_events_config.json→.yaml,default_otel_config.json→.yaml)Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.