Rename IMDSCredentialRefresher to IMDSCredentialsRefresher#4969
Merged
Conversation
Align with the plural naming used by sibling types in the credentials package (CredentialsManager, IAMRoleCredentials). Single-entity types (TaskCredential) and per-credential methods (upsertCredential, parseCredentialKey, etc.) stay singular per Go entity convention.
mye956
approved these changes
May 21, 2026
danehlim
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the IMDSCredentialRefresher to IMDSCredentialsRefresher, while the feature is disabled and being built.
This aligns it with the plural naming used by sibling types in the credentials package (CredentialsManager, IAMRoleCredentials). Single-entity types (TaskCredential) and per-credential methods (upsertCredential, parseCredentialKey, etc.) stay singular per Go entity convention.
This will also align the naming with our sibling containerd-based ECS agent.
Implementation details
Self-explainatory, rename-only change, no new functional change.
Testing
New tests cover the changes: no, relying on PR checks. rename is also across test files as needed.
Description for the changelog
Enhancement - rename IMDSCredentialRefresher to IMDSCredentialsRefresher
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions? No
Does this PR include the addition of new environment variables in the README? No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.