Skip to content

Switching to v1 admission review#255

Open
yue9944882 wants to merge 1 commit into
aws:masterfrom
yue9944882:v1-admission-review
Open

Switching to v1 admission review#255
yue9944882 wants to merge 1 commit into
aws:masterfrom
yue9944882:v1-admission-review

Conversation

@yue9944882
Copy link
Copy Markdown
Contributor

This PR bumps the admission review related k8s types from v1beta1 to v1 as k/k has promoted the v1 API to GA on 1.30:

kubernetes/kubernetes#123405

@yue9944882 yue9944882 requested a review from a team as a code owner January 29, 2025 23:51
@yue9944882
Copy link
Copy Markdown
Contributor Author

/hold

for further discussion

Signed-off-by: Min Jin <minkimzz@amazon.com>
@hernan82arg
Copy link
Copy Markdown

We really need this, since we've upgraded we lost the ability to use it. Will you be looking into this in the near future? Should we look for other solutions?

thanks in advance!!!

@notori0us
Copy link
Copy Markdown

hi friends, any reason we are holding on this?

@SeoGeonhyuk
Copy link
Copy Markdown

Hi, I've been struggling with the received invalid webhook response: expected webhook response of admission.k8s.io/v1, Kind=AdmissionReview, got /, Kind= error on Kubernetes v1.32 with the latest image.

While waiting for this PR to be merged, I found a workaround:

Change the order of admissionReviewVersions in MutatingWebhookConfiguration from ["v1", "v1beta1"] to ["v1beta1", "v1"]. This forces the API server to use v1beta1 when calling the webhook, which the current implementation can handle.

kubectl patch mutatingwebhookconfiguration pod-identity-webhook --type=json \
  -p='[{"op": "replace", "path": "/webhooks/0/admissionReviewVersions", "value": ["v1beta1", "v1"]}]'

This is obviously just a temporary workaround until this PR gets merged. Please consider merging this — the webhook is completely broken on Kubernetes 1.30+ without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants