Added readinessProbe to webhook deployment#287
Open
sotoiwa wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a readinessProbe to prevent traffic from being routed to webhook pods before they're ready to handle requests.
Problem
Without readinessProbe, webhook pods receive traffic immediately after startup, which can cause "connection refused" errors during cluster operations (upgrades, rolling updates). Due to
failurePolicy: Ignore, pods are created without expected IAM role mutations.Solution
Added readinessProbe using the existing
/healthzendpoint:Related Issues
While the current
/healthzendpoint is basic, it ensures the webhook server is at least accepting connections before receiving traffic, significantly improving reliability during cluster operations.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.