Add preStop hook to prevent webhook failures during pod termination#290
Open
sotoiwa wants to merge 1 commit into
Open
Add preStop hook to prevent webhook failures during pod termination#290sotoiwa wants to merge 1 commit into
sotoiwa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#289
Description of changes:
This PR adds a preStop hook with sleep action to the webhook deployment to prevent connection failures during pod termination.
Changes:
lifecycle.preStop.sleepconfiguration with 10-second delay to the webhook containerProblem solved:
During cluster operations (node drain, upgrade, pod deletion), the webhook experiences connection failures because pods receive traffic while terminating. This occurs due to the timing gap between pod termination start and Endpoints removal.
Technical details:
The preStop hook delays SIGTERM delivery, allowing time for:
The native sleep action is available since Kubernetes 1.29 (alpha) and 1.30+ (beta, enabled by default).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.