Skip to content

bskiser/fix token refresh#1920

Merged
chaynabors merged 3 commits into
mainfrom
bskiser/fix-token-refresh
May 21, 2025
Merged

bskiser/fix token refresh#1920
chaynabors merged 3 commits into
mainfrom
bskiser/fix-token-refresh

Conversation

@brandonskiser

@brandonskiser brandonskiser commented May 21, 2025

Copy link
Copy Markdown
Contributor

Description of changes:

  • Refreshing the token for some users is failing. This seems to be because we are not saving the device registration to the auth_kv table when launching q chat - this is required for token refresh to succeed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter

codecov-commenter commented May 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.75%. Comparing base (12d49f2) to head (16526aa).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1920   +/-   ##
=======================================
  Coverage   16.75%   16.75%           
=======================================
  Files         213      213           
  Lines       20704    20704           
  Branches      871      871           
=======================================
  Hits         3468     3468           
  Misses      17236    17236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandonskiser brandonskiser requested a review from chaynabors May 21, 2025 00:58
@brandonskiser brandonskiser marked this pull request as ready for review May 21, 2025 01:32
@chaynabors chaynabors merged commit 972adf4 into main May 21, 2025
21 checks passed
@chaynabors chaynabors deleted the bskiser/fix-token-refresh branch May 21, 2025 02:27
This was referenced May 21, 2025
hayemaxi pushed a commit to hayemaxi/amazon-q-developer-cli that referenced this pull request May 22, 2025
* chore: add logs for refreshing token

* fix: save device registration when launching chat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants