Skip to content

fix: add stalled stream protection config to SSO client #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dingfeli merged 1 commit into from
May 21, 2025
Merged

fix: add stalled stream protection config to SSO client #1929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/chat-cli/src/auth/builder_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ use tracing::{
warn,
};

use crate::api_client::clients::shared::stalled_stream_protection_config;
use crate::auth::AuthError;
use crate::auth::consts::*;
use crate::auth::scope::is_scopes;
Expand Down Expand Up @@ -85,6 +86,7 @@ pub fn client(region: Region) -> Client {
.region(region)
.retry_config(RetryConfig::standard().with_max_attempts(3))
.sleep_impl(SharedAsyncSleep::new(TokioSleep::new()))
.stalled_stream_protection(stalled_stream_protection_config())
.app_name(app_name())
.build(),
)
Expand Down
6 changes: 6 additions & 0 deletions crates/fig_auth/src/builder_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ use aws_smithy_runtime_api::client::identity::{
use aws_smithy_types::error::display::DisplayErrorContext;
use aws_types::region::Region;
use aws_types::request_id::RequestId;
use aws_types::sdk_config::StalledStreamProtectionConfig;
use fig_aws_common::app_name;
use fig_telemetry_core::{
Event,
Expand Down Expand Up @@ -101,6 +102,11 @@ pub(crate) fn client(region: Region) -> Client {
.region(region)
.retry_config(retry_config)
.sleep_impl(SharedAsyncSleep::new(TokioSleep::new()))
.stalled_stream_protection(
StalledStreamProtectionConfig::enabled()
.grace_period(std::time::Duration::from_secs(60))
.build(),
)
.app_name(app_name())
.build();
Client::new(&sdk_config)
Expand Down
Loading