amazon-s3-encryption-client-java/src/test/java/software/amazon/encryption/s3/ParameterMalleabilityTest.java at a8a377d6fc8e54c9fcaee615c10805115a0b94d7 · aws/amazon-s3-encryption-client-java · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
package software.amazon.encryption.s3;

import org.junit.jupiter.api.BeforeAll;
import org.junitpioneer.jupiter.RetryingTest;
import software.amazon.awssdk.core.ResponseInputStream;
import software.amazon.awssdk.core.sync.RequestBody;
import software.amazon.awssdk.services.s3.S3Client;
import software.amazon.awssdk.services.s3.model.GetObjectResponse;
import software.amazon.encryption.s3.algorithms.AlgorithmSuite;

import javax.crypto.KeyGenerator;
import javax.crypto.SecretKey;
import java.security.NoSuchAlgorithmException;
import java.util.HashMap;
import java.util.Map;

import static org.junit.jupiter.api.Assertions.assertThrows;
import static software.amazon.encryption.s3.utils.S3EncryptionClientTestResources.BUCKET;
import static software.amazon.encryption.s3.utils.S3EncryptionClientTestResources.appendTestSuffix;
import static software.amazon.encryption.s3.utils.S3EncryptionClientTestResources.deleteObject;

public class ParameterMalleabilityTest {

    private static SecretKey AES_KEY;

    @BeforeAll
    public static void setUp() throws NoSuchAlgorithmException {
        KeyGenerator keyGen = KeyGenerator.getInstance("AES");
        keyGen.init(256);
        AES_KEY = keyGen.generateKey();
    }

    @RetryingTest(3)
    public void contentEncryptionDowngradeAttackFails() {
        final String objectKey = appendTestSuffix("content-downgrade-attack-fails");
        S3Client s3Client = S3EncryptionClient.builderV4()
                .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT)
                .encryptionAlgorithm(AlgorithmSuite.ALG_AES_256_GCM_IV12_TAG16_NO_KDF)
                .aesKey(AES_KEY)

                .build();
        final String input = "ContentDowngradeAttackFails";

        // Encrypt something using AES-GCM
        s3Client.putObject(builder -> builder.bucket(BUCKET).key(objectKey), RequestBody.fromString(input));

        // Using a default client, tamper with the metadata
        // CBC mode uses no parameter value, so just remove the "cek-alg" key
        S3Client defaultClient = S3Client.builder().build();
        ResponseInputStream<GetObjectResponse> response = defaultClient.getObject(builder -> builder.bucket(BUCKET).key(objectKey));
        final Map<String, String> objectMetadata = response.response().metadata();
        final Map<String, String> tamperedMetadata = new HashMap<>(objectMetadata);
        tamperedMetadata.remove("x-amz-cek-alg");

        // Replace the object with the content encryption algorithm removed
        defaultClient.putObject(builder -> builder.bucket(BUCKET).key(objectKey).metadata(tamperedMetadata),
                RequestBody.fromInputStream(response, response.response().contentLength()));

        // getObject fails
        assertThrows(Exception.class, () -> s3Client.getObject(builder -> builder.bucket(BUCKET).key(objectKey)));

        // Enabling unauthenticated modes also fail
        S3Client s3ClientUnauthenticated = S3EncryptionClient.builderV4()
                .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT)
                .encryptionAlgorithm(AlgorithmSuite.ALG_AES_256_GCM_IV12_TAG16_NO_KDF)
                .aesKey(AES_KEY)
                .enableLegacyUnauthenticatedModes(true)
                .enableLegacyWrappingAlgorithms(true)
                .build();
        assertThrows(Exception.class, () -> s3ClientUnauthenticated.getObject(builder -> builder.bucket(BUCKET).key(objectKey)));

        // Cleanup
        deleteObject(BUCKET, objectKey, s3Client);
        s3Client.close();
    }

    @RetryingTest(3)
    public void keyWrapRemovalAttackFails() {
        final String objectKey = appendTestSuffix("keywrap-removal-attack-fails");
        S3Client s3Client = S3EncryptionClient.builderV4()
                .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT)
                .encryptionAlgorithm(AlgorithmSuite.ALG_AES_256_GCM_IV12_TAG16_NO_KDF)
                .aesKey(AES_KEY)
                .build();
        final String input = "KeyWrapRemovalAttackFails";

        // Encrypt something using AES-GCM
        s3Client.putObject(builder -> builder.bucket(BUCKET).key(objectKey), RequestBody.fromString(input));

        // Using a default client, tamper with the metadata
        S3Client defaultClient = S3Client.builder().build();
        ResponseInputStream<GetObjectResponse> response = defaultClient.getObject(builder -> builder.bucket(BUCKET).key(objectKey));
        final Map<String, String> objectMetadata = response.response().metadata();
        final Map<String, String> tamperedMetadata = new HashMap<>(objectMetadata);
        tamperedMetadata.remove("x-amz-wrap-alg");

        // Replace the object
        defaultClient.putObject(builder -> builder.bucket(BUCKET).key(objectKey).metadata(tamperedMetadata),
                RequestBody.fromInputStream(response, response.response().contentLength()));

        // getObject fails
        assertThrows(Exception.class, () -> s3Client.getObject(builder -> builder.bucket(BUCKET).key(objectKey)));

        // Enabling unauthenticated modes also fail
        S3Client s3ClientUnauthenticated = S3EncryptionClient.builderV4()
                .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT)
                .encryptionAlgorithm(AlgorithmSuite.ALG_AES_256_GCM_IV12_TAG16_NO_KDF)
                .aesKey(AES_KEY)
                .enableLegacyUnauthenticatedModes(true)
                .enableLegacyWrappingAlgorithms(true)
                .build();
        assertThrows(Exception.class, () -> s3ClientUnauthenticated.getObject(builder -> builder.bucket(BUCKET).key(objectKey)));

        // Cleanup
        deleteObject(BUCKET, objectKey, s3Client);
        s3Client.close();
    }

    @RetryingTest(3)
    public void keyWrapDowngradeAesWrapAttackFails() {
        final String objectKey = appendTestSuffix("keywrap-downgrade-aeswrap-attack-fails");
        S3Client s3Client = S3EncryptionClient.builderV4()
                .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT)
                .encryptionAlgorithm(AlgorithmSuite.ALG_AES_256_GCM_IV12_TAG16_NO_KDF)
                .aesKey(AES_KEY)
                .build();
        final String input = "KeyWrapDowngradeAesWrapAttackFails";

        // Encrypt something using AES-GCM
        s3Client.putObject(builder -> builder.bucket(BUCKET).key(objectKey), RequestBody.fromString(input));

        // Using a default client, tamper with the metadata
        S3Client defaultClient = S3Client.builder().build();
        ResponseInputStream<GetObjectResponse> response = defaultClient.getObject(builder -> builder.bucket(BUCKET).key(objectKey));
        final Map<String, String> objectMetadata = response.response().metadata();
        final Map<String, String> tamperedMetadata = new HashMap<>(objectMetadata);
        // Replace wrap-alg with AESWrap
        tamperedMetadata.put("x-amz-wrap-alg", "AESWrap");

        // Replace the object
        defaultClient.putObject(builder -> builder.bucket(BUCKET).key(objectKey).metadata(tamperedMetadata),
                RequestBody.fromInputStream(response, response.response().contentLength()));

        // getObject fails
        assertThrows(Exception.class, () -> s3Client.getObject(builder -> builder.bucket(BUCKET).key(objectKey)));

        // Enabling unauthenticated modes also fail
        S3Client s3ClientUnauthenticated = S3EncryptionClient.builderV4()
                .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT)
                .encryptionAlgorithm(AlgorithmSuite.ALG_AES_256_GCM_IV12_TAG16_NO_KDF)
                .enableLegacyWrappingAlgorithms(true)
                .enableLegacyUnauthenticatedModes(true)
                .aesKey(AES_KEY)
                .build();
        assertThrows(Exception.class, () -> s3ClientUnauthenticated.getObject(builder -> builder.bucket(BUCKET).key(objectKey)));

        // Cleanup
        deleteObject(BUCKET, objectKey, s3Client);
        s3Client.close();
    }

    @RetryingTest(3)
    public void keyWrapDowngradeAesAttackFails() {
        final String objectKey = appendTestSuffix("keywrap-downgrade-aes-attack-fails");
        S3Client s3Client = S3EncryptionClient.builderV4()
                .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT)
                .encryptionAlgorithm(AlgorithmSuite.ALG_AES_256_GCM_IV12_TAG16_NO_KDF)
                .aesKey(AES_KEY)
                .build();
        final String input = "KeyWrapDowngradeAesAttackFails";

        // Encrypt something using AES-GCM
        s3Client.putObject(builder -> builder.bucket(BUCKET).key(objectKey), RequestBody.fromString(input));

        // Using a default client, tamper with the metadata
        S3Client defaultClient = S3Client.builder().build();
        ResponseInputStream<GetObjectResponse> response = defaultClient.getObject(builder -> builder.bucket(BUCKET).key(objectKey));
        final Map<String, String> objectMetadata = response.response().metadata();
        final Map<String, String> tamperedMetadata = new HashMap<>(objectMetadata);
        // Replace wrap-alg with AES
        tamperedMetadata.put("x-amz-wrap-alg", "AES");

        // Replace the object
        defaultClient.putObject(builder -> builder.bucket(BUCKET).key(objectKey).metadata(tamperedMetadata),
                RequestBody.fromInputStream(response, response.response().contentLength()));

        // getObject fails
        assertThrows(Exception.class, () -> s3Client.getObject(builder -> builder.bucket(BUCKET).key(objectKey)));

        // Enabling unauthenticated modes also fail
        S3Client s3ClientUnauthenticated = S3EncryptionClient.builderV4()
                .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT)
                .encryptionAlgorithm(AlgorithmSuite.ALG_AES_256_GCM_IV12_TAG16_NO_KDF)
                .aesKey(AES_KEY)

                .enableLegacyWrappingAlgorithms(true)
                .enableLegacyUnauthenticatedModes(true)
                .build();
        assertThrows(Exception.class, () -> s3ClientUnauthenticated.getObject(builder -> builder.bucket(BUCKET).key(objectKey)));

        // Cleanup
        deleteObject(BUCKET, objectKey, s3Client);
        s3Client.close();
    }


}