Skip to content

fix: add builders to S3EncryptionClientException class#450

Merged
kessplas merged 7 commits intomainfrom
rishav/addBuildersToS3EncryptionClientException
Mar 25, 2025
Merged

fix: add builders to S3EncryptionClientException class#450
kessplas merged 7 commits intomainfrom
rishav/addBuildersToS3EncryptionClientException

Conversation

@rishav-karanjit
Copy link
Copy Markdown
Member

@rishav-karanjit rishav-karanjit commented Mar 4, 2025 •
edited
Loading

Issue #, if available:

Description of changes:
S3EncryptionClientException loses type due to missing builder in AWS SDK. This PR fixes it.
Fixes #449

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@seebees seebees mentioned this pull request Mar 21, 2025
Closed
1 task
@rishav-karanjit rishav-karanjit marked this pull request as ready for review March 24, 2025 16:33
@rishav-karanjit rishav-karanjit requested a review from a team as a code owner March 24, 2025 16:33
@rishav-karanjit rishav-karanjit changed the title Add builders fix: add builders to S3EncryptionClientException class Mar 24, 2025
kessplas
kessplas approved these changes Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kessplas kessplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kessplas kessplas merged commit 647c809 into main Mar 25, 2025
14 checks passed
josecorella pushed a commit that referenced this pull request Apr 16, 2025
@semantic-release-bot
Amazon S3 Encryption Client 3.3.2 Release -- 2025-04-16
4527ce1 
## [3.3.2](v3.3.1...v3.3.2) (2025-04-16)

### Fixes

* add builders to S3EncryptionClientException class ([#450](#450)) ([647c809](647c809))
* allow CipherSubscriber to determine if the part is last part ([#453](#453)) ([12355a1](12355a1))
@rishav-karanjit rishav-karanjit deleted the rishav/addBuildersToS3EncryptionClientException branch April 18, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kessplas kessplas kessplas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: S3EncryptionClientException loses type due to missing builder in AWS SDK

3 participants

@rishav-karanjit @kessplas @seebees