fix: resolve potential runtime crashes and handle carriage returns in RFC metadata parsing#954
Open
MatrixNeoKozak wants to merge 1 commit into
Open
Conversation
… RFC metadata parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements robust line-splitting and boundary checking in the RFC issue metadata parser. Previously, splitting issue bodies strictly on '\n' could leave carriage return characters ('\r') at the end of lines when processing CRLF-terminated text returned by the GitHub API. Furthermore, if the metadata table header '|PR|Champion|' was present but the body did not contain at least two subsequent lines, referencing
lines[titleIndex + 2]would result inundefinedand throw a TypeError on.split('|'). This fix replaces the single-character split with a\r?\nregular expression and adds thorough bounds and structural validation to ensure safe parsing of metadata columns.