fix(aws-ecs): suppress shouldUseCircuitBreaker warning for DAEMON scheduling services#38250
Open
gingeekrishna wants to merge 1 commit into
Open
Conversation
…services The shouldUseCircuitBreaker warning was emitted for Ec2Service and ExternalService instances created with daemon: true. The ECS circuit breaker is not applicable to DAEMON services: its failure threshold is 0.5 × desiredCount (min 3, max 200), and a DAEMON service has no desired count (one task per instance). Following the advice is meaningless, and the only way to silence it was to acknowledgeWarning with text that doesn't apply. Guard the warning with additionalProps.schedulingStrategy !== 'DAEMON', which is already set by both Ec2Service and ExternalService when daemon: true. Fixes aws#38102
github-actions
Bot
added
beginning-contributor
aws-cdk-automation
requested changes
Jul 4, 2026
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ The title scope of the pull request should omit 'aws-' from the name of modified packages. Use 'ecs' instead of 'aws-ecs'.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
There was a problem hiding this comment.
Pull request overview
This PR fixes a false-positive ECS warning by suppressing the @aws-cdk/aws-ecs:shouldUseCircuitBreaker recommendation for services using the DAEMON scheduling strategy, where the deployment circuit breaker is not meaningful.
Changes:
- Guard the
shouldUseCircuitBreakerwarning inBaseServiceso it doesn’t fire forschedulingStrategy: 'DAEMON'. - Add a regression test ensuring
Ec2Servicewithdaemon: truedoes not emit the circuit breaker suggestion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/aws-cdk-lib/aws-ecs/lib/base/base-service.ts | Adds a DAEMON scheduling-strategy guard to prevent emitting an inapplicable circuit breaker warning. |
| packages/aws-cdk-lib/aws-ecs/test/ec2/ec2-service.test.ts | Adds a regression test asserting the circuit breaker suggestion warning is not emitted for daemon services. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+120
to
+121
| const warnings = flattenMeta(app.synth().getStackByName('Stack').metadata)['/Stack/Ec2Service']['aws:cdk:warning']; | ||
| expect(warnings ?? []).not.toContainEqual(expect.stringContaining("Enable the 'circuitBreaker' property")); |
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #38102
Problem: The
@aws-cdk/aws-ecs:shouldUseCircuitBreakerwarning is emitted forEc2ServiceandExternalServiceinstances created withdaemon: true. The warning says to enable thecircuitBreakerproperty, but the ECS circuit breaker doesn't apply to DAEMON services: its failure threshold is defined as0.5 × desiredCount(min 3, max 200), and a DAEMON service has no desired count — it runs one task per instance. Following the advice is meaningless, and the only way to suppress the warning today isacknowledgeWarning(...)on text that doesn't apply.Fix: Add a
schedulingStrategy !== 'DAEMON'guard to the warning condition inBaseService. BothEc2ServiceandExternalServicealready passschedulingStrategy: props.daemon ? 'DAEMON' : ...viaadditionalProps, so the existing field covers both callers with no interface changes.Changes
packages/aws-cdk-lib/aws-ecs/lib/base/base-service.ts— one-line condition guardpackages/aws-cdk-lib/aws-ecs/test/ec2/ec2-service.test.ts— regression test asserting no circuit breaker warning fordaemon: trueservicesTesting
All existing circuit breaker tests still pass (the warning still fires for non-daemon ECS services as before).