chore: pin time crate to fix CI #2324
Merged
Merged
Conversation
time >= 0.3.37 introduces ModifierValue associated type impls that conflict with aws-smithy-types's blanket `impl<T> From<T> for CanDisable<T>` on rustc >= 1.80 (E0119). Pin time until upstream fixes the coherence issue.
Pin aws-smithy-types dependency to version 1.3
rishav-karanjit
changed the title
rishav-karanjit
changed the title
sharmabikram
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
CI is broken.
Description of changes:
smithy-rsalready has a fix in this commit but not yet released. We should revert this pin aftersmithy-rsreleases new version.aws-smithy-typeshas a coherence conflict (E0119) with time >= 0.3.37 on rustc >= 1.80. time 0.3.37+ introduces ModifierValue associated type impls that conflict with CanDisable's blanketimpl<T> From<T>. Pin time until upstream fixes it.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.