fix: validate attribute name length by UTF-8 byte count#2329
Merged
Conversation
Attribute name length was validated asymmetrically: encode only rejected keys that overflowed the 4-byte length field (~4.29 GB), while decode enforced the character-based IsValid_AttributeName (<= 65535 chars). Keys between 65,536 bytes and ~4.29 GB encrypted and persisted but were rejected on decode, making the data permanently unreadable. Add a byte-based check (1 <= |UTF8.Encode(key)| <= 65535) on both the encode (SerializeMapItem) and decode (DeserializeMapEntry) paths so over-long keys fail fast at encrypt time. The check is done in DB-ESDK rather than via IsValid_AttributeName, which is generated and inherently character-based.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.