fix(rust): bump aws-lc-rs to 1.17.0, de-dupe aws-lc-sys#2336
Merged
Conversation
Pin direct aws-lc-sys (0.41) and aws-lc-fips-sys (0.13.1) to match what aws-lc-rs 1.17.0 resolves to, so only a single copy of the aws-lc native crates compiles.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Make rust_duplicate_deps a reusable (workflow_call) workflow and invoke it from pull.yml as pr-ci-rust-duplicate-deps, adding it to the pr-ci-all-required needs list so a duplicate-aws-lc failure blocks merge. Addresses review feedback that the check must gate the required CI.
Contributor
Author
|
Per review feedback on the MPL peer PR (aws/aws-cryptographic-material-providers-library#1903): wired the duplicate-aws-lc check into the required CI gate here too. |
josecorella
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Bump
aws-lc-rsto 1.17.0, pinaws-lc-sys(0.41) /aws-lc-fips-sys(0.13.1) to the versions it resolves to so only one copy of the aws-lc native crates compiles, and add a CI check that fails on a duplicateaws-lc-sys/aws-lc-fips-sys.Example failure CI: https://github.com/aws/aws-cryptographic-material-providers-library/actions/runs/27788515222/job/82231299382
Squash/merge commit message, if applicable:
fix(rust): bump aws-lc-rs to 1.17.0 and de-dupe aws-lc-sys
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.