Skip to content

Commit 41607bc

Browse files
committed
Switch deregister/clearContext order, add JSON logging for examples
1 parent 2670530 commit 41607bc

4 files changed

Lines changed: 12 additions & 29 deletions

File tree

examples/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@
4747
<artifactId>log4j-core</artifactId>
4848
<version>2.25.3</version>
4949
</dependency>
50+
<dependency>
51+
<groupId>org.apache.logging.log4j</groupId>
52+
<artifactId>log4j-layout-template-json</artifactId>
53+
<version>2.25.3</version>
54+
</dependency>
5055

5156
<!-- Testing -->
5257
<dependency>

examples/src/main/resources/log4j2.xml

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,16 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Configuration status="WARN">
33
<Appenders>
4-
<!-- Default appender without MDC -->
54
<Console name="Console" target="SYSTEM_OUT">
6-
<PatternLayout pattern="%d{HH:mm:ss.SSS} %-5level %logger{36} - %msg%n"/>
7-
</Console>
8-
9-
<!-- Appender with MDC for DurableContext logs -->
10-
<Console name="Durable" target="SYSTEM_OUT">
11-
<PatternLayout pattern="%d{HH:mm:ss.SSS} %-5level %logger{36} - %msg%notEmpty{ | arn=%X{durableExecutionArn}}%notEmpty{ id=%X{operationId}}%notEmpty{ op=%X{operationName}}%notEmpty{ attempt=%X{attempt}}%n"/>
5+
<JsonTemplateLayout eventTemplateUri="classpath:EcsLayout.json"/>
126
</Console>
137
</Appenders>
148

159
<Loggers>
16-
<!-- DurableContext uses the MDC appender -->
17-
<Logger name="com.amazonaws.lambda.durable.DurableContext" level="DEBUG" additivity="false">
18-
<AppenderRef ref="Durable"/>
19-
</Logger>
20-
21-
<!-- SDK logs at DEBUG -->
10+
<!-- SDK internal logs at WARN -->
2211
<Logger name="com.amazonaws.lambda.durable" level="WARN"/>
2312

24-
<!-- AWS SDK logs at WARN (suppress verbose debug) -->
13+
<!-- AWS SDK logs at WARN -->
2514
<Logger name="software.amazon.awssdk" level="WARN"/>
2615

2716
<!-- Everything else at INFO -->

examples/src/test/resources/log4j2-test.xml

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,16 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Configuration status="WARN">
33
<Appenders>
4-
<!-- Default appender without MDC -->
54
<Console name="Console" target="SYSTEM_OUT">
6-
<PatternLayout pattern="%d{HH:mm:ss.SSS} %-5level %logger{36} - %msg%n"/>
7-
</Console>
8-
9-
<!-- Appender with MDC for DurableContext logs -->
10-
<Console name="Durable" target="SYSTEM_OUT">
11-
<PatternLayout pattern="%d{HH:mm:ss.SSS} %-5level %logger{36} - %msg%notEmpty{ | arn=%X{durableExecutionArn}}%notEmpty{ id=%X{operationId}}%notEmpty{ op=%X{operationName}}%notEmpty{ attempt=%X{attempt}}%n"/>
5+
<JsonTemplateLayout eventTemplateUri="classpath:EcsLayout.json"/>
126
</Console>
137
</Appenders>
148

159
<Loggers>
16-
<!-- DurableContext uses the MDC appender -->
17-
<Logger name="com.amazonaws.lambda.durable.DurableContext" level="DEBUG" additivity="false">
18-
<AppenderRef ref="Durable"/>
19-
</Logger>
20-
21-
<!-- SDK logs at DEBUG -->
10+
<!-- SDK internal logs at DEBUG for testing -->
2211
<Logger name="com.amazonaws.lambda.durable" level="DEBUG"/>
2312

24-
<!-- AWS SDK logs at WARN (suppress verbose debug) -->
13+
<!-- AWS SDK logs at WARN -->
2514
<Logger name="software.amazon.awssdk" level="WARN"/>
2615

2716
<!-- Everything else at INFO -->

sdk/src/main/java/com/amazonaws/lambda/durable/operation/StepOperation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ private void executeStepLogic(int attempt) {
208208
} catch (Throwable e) {
209209
handleStepError(e, attempt);
210210
} finally {
211-
durableLogger.clearOperationContext();
212211
executionManager.deregisterActiveThread(stepThreadId);
212+
durableLogger.clearOperationContext();
213213
}
214214
});
215215
}

0 commit comments

Comments
 (0)