Skip to content

Commit bac79a8

Browse files
committed
update comments
1 parent ca0e217 commit bac79a8

3 files changed

Lines changed: 2 additions & 6 deletions

File tree

sdk/src/main/java/com/amazonaws/lambda/durable/execution/CheckpointBatcher.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class CheckpointBatcher {
4949
MAX_ITEM_COUNT, MAX_BATCH_SIZE_BYTES, CheckpointBatcher::estimateSize, this::checkpointBatch);
5050
}
5151

52-
/** Queues a operation update for batched checkpoint */
52+
/** Queues an operation update for batched checkpoint */
5353
CompletableFuture<Void> checkpoint(OperationUpdate update) {
5454
logger.debug("Checkpoint request received: Action {}", update.action());
5555
return checkpointApiRequestBatcher.submit(update, config.getCheckpointDelay());
@@ -139,10 +139,6 @@ private void checkpointBatch(List<OperationUpdate> updates) {
139139
logger.debug("Durable checkpoint API called (latency={}ns): {}.", System.nanoTime() - startTime, response);
140140

141141
// Notify callback of completion
142-
// TODO: sam local backend returns no new execution state when called with zero
143-
// updates. WHY?
144-
// This means the polling will never receive an operation update and complete
145-
// the Phaser.
146142
checkpointToken = response.checkpointToken();
147143
if (response.newExecutionState() != null) {
148144
// fetch all pages of operations

sdk/src/main/java/com/amazonaws/lambda/durable/execution/ExecutionManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
* <li>Phaser management (coordination)
3333
* <li>Checkpoint batching (via CheckpointManager)
3434
* <li>Polling (for waits and retries)
35+
* <li>operationCounter (to generate the next OperationId)
3536
* </ul>
3637
*
3738
* <p>This is the single entry point for all execution coordination. Internal coordination (polling, checkpointing) uses

sdk/src/test/java/com/amazonaws/lambda/durable/execution/ExecutionManagerTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ void nextOperationId() {
5050
assertEquals("3", manager.nextOperationId());
5151
}
5252

53-
5453
@Test
5554
void startsInReplayModeWhenOperationsExist() {
5655
var manager = createManager(List.of(executionOp(), stepOp("1", OperationStatus.SUCCEEDED)));

0 commit comments

Comments
 (0)