[fix]: fix ConcurrentModificationException when completing invocations#362
Merged
Conversation
68f8a26 to
579fad8
Compare
579fad8 to
d7536c7
Compare
wangyb-A
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Fixes: #361
Description
ConcurrentModificationException, which is thrown when an invocation is completed and validating the operations.SynchronizedMapwas used to store the operations and the operations might be updated when validating them because operations running in the background (e.g. skipped map items) could be completed when validating.Fix:
Replaced
SynchronizedMapwithConcurrentHashMapthat is safe to iterate when being updatedFix:
Check the branch's existence in the checkpointed result when adding a new branch
Demo/Screenshots
Repeated the tests 40000+ times and the exception wasn't thrown
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? N/A
Integration Tests
Have integration tests been written for these changes? The two bugs were caught by existing tests
Examples
Has a new example been added for the change? (if applicable)