feat(sdk): Add subtypes for Step, Wait, Callback and Invoke operations#404
Closed
nvasiu wants to merge 1 commit into
Closed
feat(sdk): Add subtypes for Step, Wait, Callback and Invoke operations#404nvasiu wants to merge 1 commit into
nvasiu wants to merge 1 commit into
Conversation
Added new OperationSubType values for all operation types that were missing them (step, wait, callback and invoke). And pass these values when creating operations in DurableContextImpl. ChildContextOperation explicitly checks for unreachable subtypes. Updated ChildContextOperation to check for the new subtype values. Updated the tests for the above operations that check the subtype to use these new subtype values. Updated LocalMemoryExecutionClient.applyResult to preserve subtype when updating an operation. Previously the subtype value was not passed on to the updated operation, causing test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#396
Description
Added new OperationSubType values for all operation types that were missing them (step, wait, callback and invoke). And pass these values when creating operations in DurableContextImpl.
ChildContextOperation explicitly checks for unreachable subtypes. Updated ChildContextOperation to check for the new subtype values.
Updated the tests for the above operations that check the subtype to use these new subtype values.
Updated LocalMemoryExecutionClient.applyResult to preserve subtype when updating an operation. Previously the subtype value was not passed on to the updated operation, causing test failures.
Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? Updated Tests
Integration Tests
Have integration tests been written for these changes? Updated Tests
Examples
Has a new example been added for the change? (if applicable) N/A