-
Notifications
You must be signed in to change notification settings - Fork 19
Expand file tree
/
Copy pathwait_for_condition_test.py
More file actions
1321 lines (1045 loc) · 42.2 KB
/
Copy pathwait_for_condition_test.py
File metadata and controls
1321 lines (1045 loc) · 42.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
"""Unit tests for wait_for_condition operation."""
import datetime
import json
from unittest.mock import Mock
import pytest
from aws_durable_execution_sdk_python.config import Duration
from aws_durable_execution_sdk_python.exceptions import (
CallableRuntimeError,
InvocationError,
SuspendExecution,
)
from aws_durable_execution_sdk_python.identifier import OperationIdentifier
from aws_durable_execution_sdk_python.lambda_service import (
ErrorObject,
Operation,
OperationStatus,
OperationType,
StepDetails,
)
from aws_durable_execution_sdk_python.logger import Logger, LogInfo
from aws_durable_execution_sdk_python.operation.wait_for_condition import (
WaitForConditionOperationExecutor,
)
from aws_durable_execution_sdk_python.state import CheckpointedResult, ExecutionState
from aws_durable_execution_sdk_python.types import WaitForConditionCheckContext
from aws_durable_execution_sdk_python.waits import (
WaitForConditionConfig,
WaitForConditionDecision,
)
from tests.serdes_test import CustomDictSerDes
# Test helper - maintains old handler signature for backward compatibility in tests
def wait_for_condition_handler(
check, config, state, operation_identifier, context_logger
):
"""Test helper that wraps WaitForConditionOperationExecutor with old handler signature."""
executor = WaitForConditionOperationExecutor(
check=check,
config=config,
state=state,
operation_identifier=operation_identifier,
context_logger=context_logger,
)
return executor.process()
def test_wait_for_condition_first_execution_condition_met():
"""Test wait_for_condition on first execution when condition is met."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
def wait_strategy(state, attempt):
return WaitForConditionDecision.stop_polling()
config = WaitForConditionConfig(initial_state=5, wait_strategy=wait_strategy)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result == 6
assert mock_state.create_checkpoint.call_count == 2 # START and SUCCESS
def test_wait_for_condition_first_execution_condition_not_met():
"""Test wait_for_condition on first execution when condition is not met."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
def wait_strategy(state, attempt):
return WaitForConditionDecision.continue_waiting(Duration.from_seconds(30))
config = WaitForConditionConfig(initial_state=5, wait_strategy=wait_strategy)
with pytest.raises(SuspendExecution, match="will retry in 30 seconds"):
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert mock_state.create_checkpoint.call_count == 2 # START and RETRY
def test_wait_for_condition_already_succeeded():
"""Test wait_for_condition when already completed successfully."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "test_arn"
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.SUCCEEDED,
step_details=StepDetails(result=json.dumps(42)),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result == 42
assert mock_state.create_checkpoint.call_count == 0 # No new checkpoints
def test_wait_for_condition_already_succeeded_none_result():
"""Test wait_for_condition when already completed with None result."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "test_arn"
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.SUCCEEDED,
step_details=StepDetails(result=None),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result is None
def test_wait_for_condition_already_failed():
"""Test wait_for_condition when already failed."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "test_arn"
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.FAILED,
step_details=StepDetails(
error=ErrorObject("Test error", "TestError", None, None)
),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
with pytest.raises(CallableRuntimeError):
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
def test_wait_for_condition_retry_with_state():
"""Test wait_for_condition on retry with previous state."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.STARTED,
step_details=StepDetails(result=json.dumps(10), attempt=2),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result == 11 # 10 (from checkpoint) + 1
assert mock_state.create_checkpoint.call_count == 1 # Only SUCCESS
def test_wait_for_condition_retry_without_state():
"""Test wait_for_condition on retry without previous state."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.STARTED,
step_details=StepDetails(result=None, attempt=2),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result == 6 # 5 (initial) + 1
def test_wait_for_condition_retry_invalid_json_state():
"""Test wait_for_condition on retry with invalid JSON state."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.STARTED,
step_details=StepDetails(result="invalid json", attempt=2),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result == 6 # Falls back to initial state
def test_wait_for_condition_check_function_exception():
"""Test wait_for_condition when check function raises exception."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
msg = "Test error"
raise ValueError(msg)
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
with pytest.raises(ValueError, match="Test error"):
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert mock_state.create_checkpoint.call_count == 2 # START and FAIL
def test_wait_for_condition_check_context():
"""Test that check function receives proper context."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
captured_context = None
def check_func(state, context):
nonlocal captured_context
captured_context = context
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert isinstance(captured_context, WaitForConditionCheckContext)
assert captured_context.logger is mock_logger
def test_wait_for_condition_delay_seconds_none():
"""Test wait_for_condition with None delay_seconds."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
def wait_strategy(state, attempt):
return WaitForConditionDecision(should_continue=True, delay=Duration())
config = WaitForConditionConfig(initial_state=5, wait_strategy=wait_strategy)
with pytest.raises(SuspendExecution, match="will retry in 0 seconds"):
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
def test_wait_for_condition_no_operation_in_checkpoint():
"""Test wait_for_condition when checkpoint has no operation."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
# Create a mock result that is started but has no operation
mock_result = Mock()
mock_result.is_succeeded.return_value = False
mock_result.is_failed.return_value = False
mock_result.is_pending.return_value = False
mock_result.is_started_or_ready.return_value = True
mock_result.is_existent.return_value = True
mock_result.result = json.dumps(10)
mock_result.operation = None
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result == 11 # Uses attempt=1 by default
def test_wait_for_condition_operation_no_step_details():
"""Test wait_for_condition when operation has no step_details."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
# Create operation without step_details
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.STARTED,
step_details=None,
)
mock_result = CheckpointedResult.create_from_operation(operation)
# Mock the result property since CheckpointedResult is frozen
mock_result = Mock()
mock_result.is_succeeded.return_value = False
mock_result.is_failed.return_value = False
mock_result.is_pending.return_value = False
mock_result.is_started_or_ready.return_value = True
mock_result.is_existent.return_value = True
mock_result.result = json.dumps(10)
mock_result.operation = operation
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result == 11 # Uses attempt=1 by default
def test_wait_for_condition_custom_delay_seconds():
"""Test wait_for_condition with custom delay_seconds."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
def wait_strategy(state, attempt):
return WaitForConditionDecision(
should_continue=True, delay=Duration.from_minutes(1)
)
config = WaitForConditionConfig(initial_state=5, wait_strategy=wait_strategy)
with pytest.raises(SuspendExecution, match="will retry in 60 seconds"):
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
def test_wait_for_condition_attempt_number_passed_to_strategy():
"""Test that attempt number is correctly passed to wait strategy."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.STARTED,
step_details=StepDetails(result=json.dumps(10), attempt=3),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
captured_attempt = None
def wait_strategy(state, attempt):
nonlocal captured_attempt
captured_attempt = attempt
return WaitForConditionDecision.stop_polling()
config = WaitForConditionConfig(initial_state=5, wait_strategy=wait_strategy)
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert captured_attempt == 4
def test_wait_for_condition_attempt_sequence_is_monotonic():
"""Test that attempt numbers form a monotonically increasing sequence: 1, 2, 3, 4...
This test validates the fix for the attempt counting bug where:
- First execution (no checkpoint): attempt = 1
- After first retry (checkpoint.attempt = 1): attempt = 2
- After second retry (checkpoint.attempt = 2): attempt = 3
- After third retry (checkpoint.attempt = 3): attempt = 4
The current attempt should always be: checkpointed_attempts + 1
"""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
captured_attempts = []
def wait_strategy(state, attempt):
captured_attempts.append(attempt)
return WaitForConditionDecision.stop_polling()
config = WaitForConditionConfig(initial_state=5, wait_strategy=wait_strategy)
# Test 1: First execution (no checkpoint exists)
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert captured_attempts[-1] == 1, "First execution should have attempt=1"
# Test 2: After first retry (checkpoint has attempt=1)
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.STARTED,
step_details=StepDetails(result=json.dumps(10), attempt=1),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert (
captured_attempts[-1] == 2
), "After first retry (checkpoint.attempt=1), current attempt should be 2"
# Test 3: After second retry (checkpoint has attempt=2)
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.STARTED,
step_details=StepDetails(result=json.dumps(10), attempt=2),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert (
captured_attempts[-1] == 3
), "After second retry (checkpoint.attempt=2), current attempt should be 3"
# Test 4: After third retry (checkpoint has attempt=3)
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.STARTED,
step_details=StepDetails(result=json.dumps(10), attempt=3),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert (
captured_attempts[-1] == 4
), "After third retry (checkpoint.attempt=3), current attempt should be 4"
# Verify the complete sequence is monotonically increasing
assert captured_attempts == [
1,
2,
3,
4,
], f"Expected [1, 2, 3, 4] but got {captured_attempts}"
def test_wait_for_condition_state_passed_to_strategy():
"""Test that new state is correctly passed to wait strategy."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state * 2
captured_state = None
def wait_strategy(state, attempt):
nonlocal captured_state
captured_state = state
return WaitForConditionDecision.stop_polling()
config = WaitForConditionConfig(initial_state=5, wait_strategy=wait_strategy)
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert captured_state == 10 # 5 * 2
def test_wait_for_condition_logger_with_log_info():
"""Test that logger is properly configured with log info."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test:execution:123"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
)
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
# Verify logger.with_log_info was called
mock_logger.with_log_info.assert_called_once()
call_args = mock_logger.with_log_info.call_args[0][0]
assert isinstance(call_args, LogInfo)
def test_wait_for_condition_zero_delay_seconds():
"""Test wait_for_condition with zero delay_seconds."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
def wait_strategy(state, attempt):
return WaitForConditionDecision(
should_continue=True, delay=Duration.from_seconds(0)
)
config = WaitForConditionConfig(initial_state=5, wait_strategy=wait_strategy)
with pytest.raises(SuspendExecution, match="will retry in 0 seconds"):
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
def test_wait_for_condition_custom_serdes_first_execution_condition_met():
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
complex_result = {"key": "value", "number": 42, "list": [1, 2, 3]}
def check_func(state, context):
return complex_result
def wait_strategy(state, attempt):
return WaitForConditionDecision.stop_polling()
config = WaitForConditionConfig(
initial_state=5, wait_strategy=wait_strategy, serdes=CustomDictSerDes()
)
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
expected_checkpoointed_result = (
'{"key": "VALUE", "number": "84", "list": [1, 2, 3]}'
)
success_call = mock_state.create_checkpoint.call_args_list[1]
success_operation = success_call[1]["operation_update"]
assert success_operation.payload == expected_checkpoointed_result
def test_wait_for_condition_custom_serdes_already_succeeded():
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "test_arn"
operation = Operation(
operation_id="op1",
operation_type=OperationType.STEP,
status=OperationStatus.SUCCEEDED,
step_details=StepDetails(
result='{"key": "VALUE", "number": "84", "list": [1, 2, 3]}'
),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
return state + 1
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
serdes=CustomDictSerDes(),
)
result = wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
assert result == {"key": "value", "number": 42, "list": [1, 2, 3]}
def test_wait_for_condition_pending():
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
operation = Operation(
operation_id="XXX",
operation_type=OperationType.STEP,
status=OperationStatus.PENDING,
step_details=StepDetails(
result='{"key": "VALUE", "number": "84", "list": [1, 2, 3]}',
next_attempt_timestamp=datetime.datetime.fromtimestamp(
1764547200, tz=datetime.UTC
),
),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
msg = "Should not be called"
raise InvocationError(msg)
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
serdes=CustomDictSerDes(),
)
with pytest.raises(
SuspendExecution, match="wait_for_condition test_wait will retry at timestamp"
):
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
def test_wait_for_condition_pending_without_next_attempt():
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
operation = Operation(
operation_id="XXX",
operation_type=OperationType.STEP,
status=OperationStatus.PENDING,
step_details=StepDetails(
result='{"key": "VALUE", "number": "84", "list": [1, 2, 3]}',
),
)
mock_result = CheckpointedResult.create_from_operation(operation)
mock_state.get_checkpoint_result.return_value = mock_result
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger
op_id = OperationIdentifier("op1", None, "test_wait")
def check_func(state, context):
msg = "Should not be called"
raise InvocationError(msg)
config = WaitForConditionConfig(
initial_state=5,
wait_strategy=lambda s, a: WaitForConditionDecision.stop_polling(),
serdes=CustomDictSerDes(),
)
with pytest.raises(
SuspendExecution,
match="No timestamp provided. Suspending without retry timestamp.",
):
wait_for_condition_handler(
state=mock_state,
operation_identifier=op_id,
check=check_func,
config=config,
context_logger=mock_logger,
)
# Immediate Response Handling Tests
def test_wait_for_condition_checkpoint_called_once_with_is_sync_false():
"""Test that get_checkpoint_result is called once when checkpoint is created (is_sync=False)."""
mock_state = Mock(spec=ExecutionState)
mock_state.durable_execution_arn = "arn:aws:test"
mock_state.get_checkpoint_result.return_value = (
CheckpointedResult.create_not_found()
)
mock_logger = Mock(spec=Logger)
mock_logger.with_log_info.return_value = mock_logger