Skip to content

CMake installation location is unusual #810

@dawesc

Description

@dawesc

Security issue notifications

If you discover a potential security issue in the AWS Encryption SDK we ask that you notify AWS Security via our vulnerability reporting page. Please do not create a public GitHub issue.

Problem:

The installation of the .cmake files is unusual (not for example the same as the aws-sdk-cpp ); it's more common to install the cmake config to lib/cmake/project/project-config.cmake and in this way it's easy to pick up and use in dependent projects. Changing this location I can see this being an issue to people who've already worked around this so you may well not want to do this but i bring it up as it would make my life easier.

Solution:

Change the installation directory (or maybe even do both for a while for backward compatibility) in InstallLogic.cmake from ${AWS_INSTALL_TARGET}/cmake to cmake/${AWS_INSTALL_TARGET}

Out of scope:

Nothing

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions