Remove experimental flag from Rust Cargo Lambda workflow (#833)

The Rust Cargo Lambda workflow no longer requires the
experimentalCargoLambda feature flag to be enabled. This promotes
the workflow to a stable, generally available builder.

- Remove experimental flag check from RustCargoLambdaWorkflow.__init__
- Delete feature_flag.py module
- Update unit and integration tests to remove flag usage

Author: bnusunny

aws_lambda_builders/workflows/rust_cargo/feature_flag.py

@@ -8,8 +8,6 @@
 
 from .actions import RustCargoLambdaBuildAction, RustCopyAndRenameAction
 from .cargo_lambda import SubprocessCargoLambda
-from .exceptions import CargoLambdaExecutionException
-from .feature_flag import is_experimental_cargo_lambda_scope
 
 
 class RustCargoLambdaWorkflow(BaseWorkflow):
@@ -36,11 +34,6 @@ def __init__(
         super(RustCargoLambdaWorkflow, self).__init__(
             source_dir, artifacts_dir, scratch_dir, manifest_path, runtime=runtime, **kwargs
         )
-        if not is_experimental_cargo_lambda_scope(self.experimental_flags):
-            raise CargoLambdaExecutionException(
-                message="Feature flag `experimentalCargoLambda` must be enabled to use this workflow"
-            )
-
         # we utilize the handler identifier to
         # select the binary to build
         options = kwargs.get("options") or {}

aws_lambda_builders/workflows/rust_cargo/workflow.py

@@ -6,7 +6,6 @@
 
 from aws_lambda_builders.builder import LambdaBuilder
 from aws_lambda_builders.exceptions import WorkflowFailedError
-from aws_lambda_builders.workflows.rust_cargo.feature_flag import EXPERIMENTAL_FLAG_CARGO_LAMBDA
 
 
 def rm_target(base):
@@ -43,7 +42,6 @@ def test_failed_build_project(self):
                 os.path.join(source_dir, "Cargo.toml"),
                 runtime=self.runtime,
                 options={"artifact_executable_name": "fail"},
-                experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
             )
         self.assertTrue(
             raised.exception.args[0].startswith("RustCargoLambdaBuilder:CargoLambdaBuild - Cargo Lambda failed"),
@@ -60,7 +58,6 @@ def test_builds_hello_project(self):
             self.scratch_dir,
             os.path.join(source_dir, "Cargo.toml"),
             runtime=self.runtime,
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
 
         expected_files = {"bootstrap"}
@@ -79,7 +76,6 @@ def test_builds_hello_project_with_artifact_name(self):
             os.path.join(source_dir, "Cargo.toml"),
             runtime=self.runtime,
             options={"artifact_executable_name": "hello"},
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
 
         expected_files = {"bootstrap"}
@@ -99,7 +95,6 @@ def test_builds_hello_project_for_arm64(self):
             architecture="arm64",
             runtime=self.runtime,
             options={"artifact_executable_name": "hello"},
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
 
         expected_files = {"bootstrap"}
@@ -118,7 +113,6 @@ def test_builds_workspaces_project_with_bin_name(self):
             os.path.join(source_dir, "Cargo.toml"),
             runtime=self.runtime,
             options={"artifact_executable_name": "foo"},
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
 
         expected_files = {"bootstrap"}
@@ -137,7 +131,6 @@ def test_builds_workspace_member(self):
             self.scratch_dir,
             os.path.join(source_dir, "Cargo.toml"),
             runtime=self.runtime,
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
 
         expected_files = {"bootstrap"}
@@ -157,7 +150,6 @@ def test_builds_workspaces_project_with_package_option(self):
             os.path.join(source_dir, "Cargo.toml"),
             runtime=self.runtime,
             options={"cargo_lambda_flags": ["--package", "foo"]},
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
 
         expected_files = {"bootstrap"}
@@ -176,7 +168,6 @@ def test_builds_multi_function_project_with_function_a(self):
             os.path.join(source_dir, "Cargo.toml"),
             runtime=self.runtime,
             options={"artifact_executable_name": "function_a"},
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
 
         expected_files = {"bootstrap"}
@@ -195,7 +186,6 @@ def test_builds_multi_function_project_with_function_b(self):
             os.path.join(source_dir, "Cargo.toml"),
             runtime=self.runtime,
             options={"artifact_executable_name": "function_b"},
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
 
         expected_files = {"bootstrap"}

tests/integration/workflows/rust_cargo/test_rust_cargo.py

@@ -6,7 +6,6 @@
     RustCargoLambdaBuildAction,
     RustCopyAndRenameAction,
 )
-from aws_lambda_builders.workflows.rust_cargo.feature_flag import EXPERIMENTAL_FLAG_CARGO_LAMBDA
 
 
 class TestRustCargoLambdaWorkflow(TestCase):
@@ -21,7 +20,6 @@ def test_workflow_sets_up_builder_actions(self):
             "scratch_dir",
             "manifest",
             runtime="provided",
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
         self.assertEqual(len(workflow.actions), 2)
         self.assertIsInstance(workflow.actions[0], RustCargoLambdaBuildAction)
@@ -34,7 +32,6 @@ def test_workflow_configures_path_resolver_for_cargo(self):
             "scratch_dir",
             "manifest",
             runtime="provided",
-            experimental_flags=[EXPERIMENTAL_FLAG_CARGO_LAMBDA],
         )
         resolvers = workflow.get_resolvers()
         self.assertEqual(len(resolvers), 2)