treat warnings as errors (#2329)

* treat warnings as errors

* Change file

Author: GarrettBeatty

.autover/changes/7d00dacc-cece-4fcf-903b-f84b894eaf9e.json

@@ -0,0 +1,11 @@
+{
+  "Projects": [
+    {
+      "Name": "Amazon.Lambda.Annotations",
+      "Type": "Patch",
+      "ChangelogMessages": [
+        "treat warnings as errors and fix unshipped.md"
+      ]
+    }
+  ]
+}

Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Amazon.Lambda.Annotations.SourceGenerator.csproj

@@ -21,6 +21,7 @@
     <IncludeBuildOutput>false</IncludeBuildOutput>
 
     <Version>1.11.0</Version>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <!-- Delay setting the package id till after resolving dependencies to avoid ambigious errors. -->

Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Diagnostics/AnalyzerReleases.Unshipped.md

@@ -20,3 +20,4 @@ AWSLambda0132 | AWSLambdaCSharpGenerator | Error | Invalid ALBApiAttribute
 AWSLambda0133 | AWSLambdaCSharpGenerator | Error | ALB Listener Reference Not Found
 AWSLambda0134 | AWSLambdaCSharpGenerator | Error | FromRoute not supported on ALB functions
 AWSLambda0135 | AWSLambdaCSharpGenerator | Error | Unmapped parameter on ALB function
+AWSLambda0136 | AWSLambdaCSharpGenerator | Error | Invalid S3EventAttribute

Libraries/src/Amazon.Lambda.Annotations/APIGateway/HttpApiAuthorizerAttribute.cs

@@ -8,8 +8,8 @@ namespace Amazon.Lambda.Annotations.APIGateway
     /// </summary>
     /// <remarks>
     /// This attribute must be used in conjunction with the <see cref="LambdaFunctionAttribute"/>.
-    /// The authorizer function should return <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerV2SimpleResponse"/>
-    /// when <see cref="EnableSimpleResponses"/> is true, or <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerV2IamResponse"/>
+    /// The authorizer function should return <c>APIGatewayCustomAuthorizerV2SimpleResponse</c>
+    /// when <see cref="EnableSimpleResponses"/> is true, or <c>APIGatewayCustomAuthorizerV2IamResponse</c>
     /// when <see cref="EnableSimpleResponses"/> is false.
     /// </remarks>
     /// <example>
@@ -45,8 +45,8 @@ public class HttpApiAuthorizerAttribute : Attribute
         /// Defaults to true for simpler implementation.
         /// </summary>
         /// <remarks>
-        /// When true, the authorizer should return <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerV2SimpleResponse"/>.
-        /// When false, the authorizer should return <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerV2IamResponse"/>.
+        /// When true, the authorizer should return <c>APIGatewayCustomAuthorizerV2SimpleResponse</c>.
+        /// When false, the authorizer should return <c>APIGatewayCustomAuthorizerV2IamResponse</c>.
         /// </remarks>
         public bool EnableSimpleResponses { get; set; } = true;
 

Libraries/src/Amazon.Lambda.Annotations/APIGateway/RestApiAuthorizerAttribute.cs

@@ -26,7 +26,7 @@ public enum RestApiAuthorizerType
     /// </summary>
     /// <remarks>
     /// This attribute must be used in conjunction with the <see cref="LambdaFunctionAttribute"/>.
-    /// The authorizer function should return <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerResponse"/>.
+    /// The authorizer function should return <c>APIGatewayCustomAuthorizerResponse</c>.
     /// </remarks>
     /// <example>
     /// <code>

Libraries/src/Amazon.Lambda.Annotations/Amazon.Lambda.Annotations.csproj

@@ -12,6 +12,7 @@
     <SignAssembly>true</SignAssembly>
 
     <Version>1.11.0</Version>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">