Address PR comments

Author: normj

.autover/changes/16cc3c6a-8fa0-410b-ba57-74221abb086a.json

@@ -30,15 +30,15 @@
     },  
     {
       "Name": "Amazon.Lambda.Logging.AspNetCore",
-      "Type": "Minor",
+      "Type": "Major",
       "ChangelogMessages": [
         "Add support Lambda log levels",
 		"Change build target from .NET Standard 2.0 to .NET 6 and NET 8 to match Amazon.Lambda.AspNetCoreServer"
       ]
     },  
     {
       "Name": "Amazon.Lambda.TestUtilities",
-      "Type": "Minor",
+      "Type": "Major",
       "ChangelogMessages": [
         "Update Amazon.Lambda.TestUtitlies to have implementation of the newer logging methods",
 		"Change build target from .NET Standard 2.0 to .NET 6 and NET 8 to match Amazon.Lambda.AspNetCoreServer"

Libraries/src/Amazon.Lambda.Logging.AspNetCore/LambdaILogger.cs

@@ -28,7 +28,18 @@ public bool IsEnabled(LogLevel logLevel)
 				_options.Filter == null ||
 				_options.Filter(_categoryName, logLevel));
 		}
-
+
+        /// <summary>
+        /// The Log method called by the ILogger framework to log message to logger's target. In the Lambda case the formatted logging will be
+        /// sent to the Amazon.Lambda.Core.LambdaLogger's Log method.
+        /// </summary>
+        /// <typeparam name="TState"></typeparam>
+        /// <param name="logLevel"></param>
+        /// <param name="eventId"></param>
+        /// <param name="state"></param>
+        /// <param name="exception"></param>
+        /// <param name="formatter"></param>
+        /// <exception cref="ArgumentNullException"></exception>
         public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter)
         {
             if (formatter == null)
@@ -41,8 +52,6 @@ public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Except
                 return;
             }
 
-            var lambdaLogLevel = ConvertLogLevel(logLevel);
-
             var components = new List<string>(4);
             if (_options.IncludeLogLevel)
             {
@@ -74,6 +83,7 @@ public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Except
 
             var finalText = string.Join(" ", components);
 
+            var lambdaLogLevel = ConvertLogLevel(logLevel);
             Amazon.Lambda.Core.LambdaLogger.Log(lambdaLogLevel, finalText);
         }
 

Libraries/src/Amazon.Lambda.RuntimeSupport/Bootstrap/UserCodeLoader.cs

@@ -150,6 +150,13 @@ public void Invoke(Stream lambdaData, ILambdaContext lambdaContext, Stream outSt
             _invokeDelegate(lambdaData, lambdaContext, outStream);
         }
 
+        /// <summary>
+        /// Sets the backing logger action field in Amazon.Logging.Core to redirect logs into Amazon.Lambda.RuntimeSupport.
+        /// </summary>
+        /// <param name="coreAssembly"></param>
+        /// <param name="customerLoggingAction"></param>
+        /// <param name="internalLogger"></param>
+        /// <exception cref="ArgumentNullException"></exception>
         internal static void SetCustomerLoggerLogAction(Assembly coreAssembly, Action<string> customerLoggingAction, InternalLogger internalLogger)
         {
             if (coreAssembly == null)
@@ -188,6 +195,14 @@ internal static void SetCustomerLoggerLogAction(Assembly coreAssembly, Action<st
             }
         }
 
+        /// <summary>
+        /// Sets the backing logger action field in Amazon.Logging.Core to redirect logs into Amazon.Lambda.RuntimeSupport.
+        /// </summary>
+        /// <param name="coreAssembly"></param>
+        /// <param name="loggingWithLevelAction"></param>
+        /// <param name="internalLogger"></param>
+        /// <exception cref="ArgumentNullException"></exception>
+
         internal static void SetCustomerLoggerLogAction(Assembly coreAssembly, Action<string, string, object[]> loggingWithLevelAction, InternalLogger internalLogger)
         {
             if (coreAssembly == null)
@@ -226,6 +241,13 @@ internal static void SetCustomerLoggerLogAction(Assembly coreAssembly, Action<st
             }
         }
 
+        /// <summary>
+        /// Sets the backing logger action field in Amazon.Logging.Core to redirect logs into Amazon.Lambda.RuntimeSupport.
+        /// </summary>
+        /// <param name="coreAssembly"></param>
+        /// <param name="loggingWithAndExceptionLevelAction"></param>
+        /// <param name="internalLogger"></param>
+        /// <exception cref="ArgumentNullException"></exception>
         internal static void SetCustomerLoggerLogAction(Assembly coreAssembly, Action<string, Exception, string, object[]> loggingWithAndExceptionLevelAction, InternalLogger internalLogger)
         {
             if (coreAssembly == null)

Libraries/src/Amazon.Lambda.TestUtilities/TestLambdaLogger.cs

@@ -38,13 +38,24 @@ public void LogLine(string message)
             Console.WriteLine(message);
         }
 
+        /// <summary>
+        /// Write log messages to the console and the Buffer.
+        /// </summary>
+        /// <param name="level"></param>
+        /// <param name="message"></param>
         public void Log(string level, string message)
         {
             var formmattedString = $"{level}: {message}";
             Buffer.AppendLine(formmattedString);
             Console.WriteLine(formmattedString);
         }
 
+        /// <summary>
+        /// Write log messages to the console and the Buffer.
+        /// </summary>
+        /// <param name="level"></param>
+        /// <param name="message"></param>
+        /// <param name="args"></param>
         public void Log(string level, string message, params object[] args)
         {
             var builder = new StringBuilder();
@@ -63,6 +74,13 @@ public void Log(string level, string message, params object[] args)
             Console.WriteLine(formmattedString);
         }
 
+        /// <summary>
+        /// Write log messages to the console and the Buffer.
+        /// </summary>
+        /// <param name="level"></param>
+        /// <param name="exception"></param>
+        /// <param name="message"></param>
+        /// <param name="args"></param>
         public void Log(string level, Exception exception, string message, params object[] args)
         {
             var builder = new StringBuilder();