Snapstart Minimal API Performance Improvements#2010
Conversation
520905f to
784e195
Compare
|
Ran the AWS CI PR check manually https://github.com/aws/aws-lambda-dotnet/actions/runs/13835574482/job/38709627134 |
fa3658e to
fc98552
Compare
c7d6057 to
b476fcd
Compare
normj
left a comment
There was a problem hiding this comment.
My reading is there are 2 different solutions being implemented here. One for AspNetCoreServer.Hosting and one for just using AspNetCoreServer. I would rather we not have different solutions and it seems like the subclasses in AspNetCoreServer.Hosting could override the virtual method for getting the list or requests to run and the service collection extension method could provide a way to get the request into that collection returned in the override.
Plus if you do it that way you can remove any changes you did to RuntimeSupport.
0d66f1c to
7915449
Compare
…et/lambda pipelines automatically during BeforeSnapshot callback.
…ing calls to HttpClient
…dependency on RuntimeSupport
da5a6e6 to
2297048
Compare
I have unified the 2 approaches so now |
2321527 to
8a6bb71
Compare
8a6bb71 to
a35a55a
Compare
a35a55a to
362aa2e
Compare
362aa2e to
d5780f3
Compare
Issue #, if available:
It is not feasible for users to warm up the asp.net and lambda pipelines via
SnapshotRestore.RegisterBeforeSnapshotwhen using .NET MinimalAPI Lambda.Description of changes:
Creates a new extension method,
AddAWSLambdaBeforeSnapshotRequestthat allows users to add a function meant to initialize the asp.net and lambda pipelines duringSnapshotRestore.RegisterBeforeSnapshot, improving the performance gains offered by SnapStart.Example:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.