Improve AddRegisterBeforeSnapshot#2071
Merged
Merged
Conversation
…d exception disposing the context (cherry picked from commit 7224bca5f8e6c95095daf4eed726fd02c7fad7f9)
1 task
normj
requested changes
May 14, 2025
Member
normj
left a comment
There was a problem hiding this comment.
Can you add the change file to the PR? Here is my stab at it but feel free to change it. Just be sure to include both Amazon.Lambda.AspNetCoreServer and Amazon.Lambda.AspNetCoreServer,Hosting in the change file.
{
"Projects": [
{
"Name": "Amazon.Lambda.AspNetCoreServer",
"Type": "Patch",
"ChangelogMessages": [
"Fixed issue when executing AddRegisterBeforeSnapshot callbacks to ensure each invocation has a new ASP.NET Core feature collection and HttpContext."
]
},
{
"Name": "Amazon.Lambda.AspNetCoreServer.Hosting",
"Type": "Patch",
"ChangelogMessages": [
"Update Amazon.Lambda.AspNetCoreServer dependency for latest patch fix."
]
}
]
}
Contributor
Author
|
Apologies, I forgot about the changelog message. Took @normj's messages verbatim :) |
normj
approved these changes
May 14, 2025
Contributor
|
ive updated the base branch to dev |
GarrettBeatty
approved these changes
May 14, 2025
Contributor
|
Rerunning tests with correct branch. https://github.com/aws/aws-lambda-dotnet/actions/runs/15049599772 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the robustness of
GetBeforeSnapshotRequests. Create a unique feature collection on every warmup call.Issue #, if available:
#2069
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.