Skip to content

Improve AddRegisterBeforeSnapshot #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GarrettBeatty merged 2 commits into from
May 15, 2025
Merged

Improve AddRegisterBeforeSnapshot #2071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77187dc
create unique feature collection on every warmup call and suppress an…
ppittle May 13, 2025
71fd000
add changelog message
ppittle May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .autover/changes/6ecba481-6957-4fd3-a562-dcf8676ab88c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"Projects": [
{
"Name": "Amazon.Lambda.AspNetCoreServer",
"Type": "Patch",
"ChangelogMessages": [
"Fixed issue when executing AddRegisterBeforeSnapshot callbacks to ensure each invocation has a new ASP.NET Core feature collection and HttpContext."
]
},
{
"Name": "Amazon.Lambda.AspNetCoreServer.Hosting",
"Type": "Patch",
"ChangelogMessages": [
"Update Amazon.Lambda.AspNetCoreServer dependency for latest patch fix."
]
}
]
}
16 changes: 8 additions & 8 deletions Libraries/src/Amazon.Lambda.AspNetCoreServer/AbstractAspNetCoreFunction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Amazon.Lambda.AspNetCoreServer.Internal;
using Amazon.Lambda.AspNetCoreServer.Internal;
using Amazon.Lambda.Core;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http.Features;
Expand Down Expand Up @@ -318,16 +318,16 @@ private void AddRegisterBeforeSnapshot()

var request = await HttpRequestMessageConverter.ConvertToLambdaRequest<TREQUEST>(httpRequest);

InvokeFeatures features = new InvokeFeatures();
(features as IItemsFeature).Items = new Dictionary<object, object>();
(features as IServiceProvidersFeature).RequestServices = _hostServices;
for (var i = 0; i < invokeTimes; i++)
{
InvokeFeatures features = new InvokeFeatures();
(features as IItemsFeature).Items = new Dictionary<object, object>();
(features as IServiceProvidersFeature).RequestServices = _hostServices;

MarshallRequest(features, request, new SnapStartEmptyLambdaContext());
MarshallRequest(features, request, new SnapStartEmptyLambdaContext());

var context = CreateContext(features);
var context = CreateContext(features);

for (var i = 0; i < invokeTimes; i++)
{
var lambdaContext = new SnapStartEmptyLambdaContext();

await ProcessRequest(lambdaContext, context, features);
Expand Down
Loading