Fix issue with long debugging sessions causing events to be retried#2072
Merged
Conversation
GarrettBeatty
approved these changes
May 15, 2025
boblodgett
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Found while using the SQS event source feature of the test tool. If the function is being debugged goes on for a few minutes the .NET SDK that sent the event to the test tool's runtime api will timeout. When it timeouts it will retry the request queuing another event. This only happens in cases where the SDK is used to post an event in request/response mode like the SQS event source.
To fix this I turned off retries on the Lambda client used to send requests and set the timeout on the client to infinite. I know infinite is a terrible choice for a real production system but since this scenario is for allowing users to debug their function that could go on for any amount of time.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.