Migrate release workflow auth to deploy key + per-repo FG PAT#2349
Open
AlexDaines wants to merge 1 commit intodevfrom
Open
Migrate release workflow auth to deploy key + per-repo FG PAT#2349AlexDaines wants to merge 1 commit intodevfrom
AlexDaines wants to merge 1 commit intodevfrom
Conversation
Switches actions/checkout from token-auth (shared PAT) to ssh-key (per-repo deploy key), and the gh CLI GITHUB_TOKEN from the shared PAT to a per-repo FG PAT. Both reads pull from per-repo Secrets Manager secrets (deploy-key + fg-pat). Depends on per-repo SM secrets being created on the bot account; do not merge before then or the workflow will fail at next release run.
AlexDaines
requested review from
GarrettBeatty and
normj
and removed request for
a team
AlexDaines
added
the
Release Not Needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches release workflow authentication off the shared FG PAT onto:
git push(viaactions/checkoutssh-key auth).gh pr create,gh release create).Files changed
.github/workflows/create-release-pr.ymland.github/workflows/sync-master-dev.yml:prod/devops/aws-lambda-dotnet-deploy-key+prod/devops/aws-lambda-dotnet-fg-pat). Dropsparse-json-secrets: truesince the new SM secrets are raw strings.actions/checkout-- switches fromtoken: ${{ env.AWS_SECRET_TOKEN }}tossh-key: ${{ env.DEPLOY_KEY }}.git pushnow runs over SSH.ghCLI calls --GITHUB_TOKENenv var swaps from${{ env.AWS_SECRET_TOKEN }}to${{ env.FG_PAT }}.Do not merge yet
This PR depends on
prod/devops/aws-lambda-dotnet-deploy-keyandprod/devops/aws-lambda-dotnet-fg-patbeing populated on the bot's credential-storage account by the change-management workstream coordinating this rollout. Merging before then would break the next release run.Why
Aligns release workflow auth with internal per-repo credential scoping: 120-day FG PAT expiry, minimum scope, deploy-key push, and a DeployKey-bypass branch ruleset replacing the shared-PAT bypass.