Harden PKCS7 and OCSP error handling#3237
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3237 +/- ##
=======================================
Coverage 78.12% 78.13%
=======================================
Files 689 689
Lines 123214 123218 +4
Branches 17137 17137
=======================================
+ Hits 96257 96271 +14
+ Misses 26047 26036 -11
- Partials 910 911 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
May 11, 2026
justsmth
approved these changes
May 11, 2026
samuel40791765
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses P409219367
Description of changes:
This PR adds hardening fixes for PKCS7 and OCSP brought up by Penpal testing:
PKCS7_dataInitdid not check the return value ofASN1_OCTET_STRING_new()inpkcs7.c. We now check for NULL.pkcs7_signature_verifyusedOPENSSL_memcmpfor digest comparison inpkcs7.c. We now useCRYPTO_memcmpfor constant-time comparison.OCSP_parse_urldid not initialize*psslalongside other output parameters inocsp_lib.c. We now initialize before any return paths.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.