Skip to content

Commit 6652dd1

Browse files
authored
fix: update esbuild build-in-source tests to nodejs24.x and CI to Node 24 (#8691)
nodejs18.x is EOL and npm registry returns 403 for esbuild on Node 18. Update CI setup-node to 24 and test runtime to nodejs24.x.
1 parent 92d867d commit 6652dd1

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ jobs:
172172
ruby-version: "3.3"
173173
- uses: actions/setup-node@v6
174174
with:
175-
node-version: 22
175+
node-version: 24
176176
- uses: actions/setup-java@v5
177177
with:
178178
distribution: 'corretto'

tests/integration/buildcmd/test_build_in_source.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def test_builds_successfully_without_local_dependencies(self, build_in_source, d
7777

7878
self._test_with_default_package_json(
7979
build_in_source=build_in_source,
80-
runtime="nodejs18.x",
80+
runtime="nodejs24.x",
8181
code_uri=codeuri,
8282
handler="main.lambdaHandler",
8383
architecture="x86_64",
@@ -91,7 +91,7 @@ def test_builds_successfully_without_local_dependencies(self, build_in_source, d
9191
@pytest.mark.flaky(reruns=3)
9292
def test_builds_successfully_with_local_dependency(self):
9393
codeuri = os.path.join(self.working_dir, "NodeWithLocalDependency")
94-
runtime = "nodejs18.x"
94+
runtime = "nodejs24.x"
9595
architecture = "x86_64"
9696

9797
self._test_with_default_package_json(
@@ -142,7 +142,7 @@ def test_builds_successfully_without_local_dependencies(self, build_in_source, e
142142
self.codeuri_path = Path(self.working_dir, "Node")
143143

144144
overrides = self.get_override(
145-
runtime="nodejs18.x", code_uri=self.codeuri_path, architecture="x86_64", handler="main.lambdaHandler"
145+
runtime="nodejs24.x", code_uri=self.codeuri_path, architecture="x86_64", handler="main.lambdaHandler"
146146
)
147147
command_list = self.get_command_list(build_in_source=build_in_source, parameter_overrides=overrides, debug=True)
148148

@@ -154,7 +154,7 @@ def test_builds_successfully_with_local_dependency(self):
154154
self.codeuri_path = Path(self.working_dir, "NodeWithLocalDependency")
155155

156156
overrides = self.get_override(
157-
runtime="nodejs18.x", code_uri=self.codeuri_path, architecture="x86_64", handler="main.lambdaHandler"
157+
runtime="nodejs24.x", code_uri=self.codeuri_path, architecture="x86_64", handler="main.lambdaHandler"
158158
)
159159
command_list = self.get_command_list(build_in_source=True, parameter_overrides=overrides)
160160

0 commit comments

Comments
 (0)