Skip to content

Commit 676b01a

Browse files
authored
chore(integ-test): use correct naming for local-start and use correct Finch filter envvar (#8399)
* nits * debug * ignore deprecation * Update integration-tests.yml
1 parent 19db921 commit 676b01a

1 file changed

Lines changed: 6 additions & 16 deletions

File tree

.github/workflows/integration-tests.yml

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ on:
88
workflow_dispatch: # Allow manual triggering
99
# NOTE: This workflow can only be manually triggered from develop or main branches
1010
# The other branch will not pass the OIDC permission check
11-
branches:
12-
- develop # Allow manual trigger on develop branch
13-
- main # Allow manual trigger on main branch
1411

1512
permissions:
1613
id-token: write # Required for OIDC
@@ -52,7 +49,7 @@ jobs:
5249
- package-delete-deploy
5350
- sync
5451
- local-invoke
55-
- local-start
52+
- local-start1
5653
- local-start2
5754
- other-and-e2e
5855
exclude:
@@ -66,7 +63,7 @@ jobs:
6663
- container_runtime: no-container
6764
test_suite: local-invoke
6865
- container_runtime: no-container
69-
test_suite: local-start
66+
test_suite: local-start1
7067
- container_runtime: no-container
7168
test_suite: local-start2
7269
- container_runtime: no-container
@@ -296,7 +293,7 @@ jobs:
296293
- name: Get testing resources and credentials
297294
run: |
298295
# Try with skip_role_deletion parameter first
299-
test_env_var=$(python3.9 tests/get_testing_resources.py skip_role_deletion 2>&1)
296+
test_env_var=$(python3.9 tests/get_testing_resources.py skip_role_deletion)
300297
301298
if [ $? -ne 0 ]; then
302299
echo "First attempt with skip_role_deletion failed, trying without parameter..."
@@ -323,13 +320,6 @@ jobs:
323320
echo "AWS_KMS_KEY=$(echo "$test_env_var" | jq -j ".TestKMSKeyArn")" >> $GITHUB_ENV
324321
echo "AWS_SIGNING_PROFILE_NAME=$(echo "$test_env_var" | jq -j ".TestSigningProfileName")" >> $GITHUB_ENV
325322
echo "AWS_SIGNING_PROFILE_VERSION_ARN=$(echo "$test_env_var" | jq -j ".TestSigningProfileARN")" >> $GITHUB_ENV
326-
327-
# Display first 6 characters of credentials for verification
328-
ACCESS_KEY=$(echo "$test_env_var" | jq -j ".accessKeyID")
329-
SECRET_KEY=$(echo "$test_env_var" | jq -j ".secretAccessKey")
330-
echo "AWS_ACCESS_KEY_ID (first 6 chars): ${ACCESS_KEY:0:6}..."
331-
echo "AWS_SECRET_ACCESS_KEY (first 6 chars): ${SECRET_KEY:0:6}..."
332-
333323
334324
- name: Login to Public ECR
335325
if: matrix.container_runtime != 'no-container' && env.BY_CANARY == 'true'
@@ -347,7 +337,7 @@ jobs:
347337
run: |
348338
# Set USING_FINCH_RUNTIME environment variable for finch tests
349339
if [ "${{ matrix.container_runtime }}" = "finch" ]; then
350-
export container_runtime="finch"
340+
export CONTAINER_RUNTIME="finch"
351341
fi
352342
353343
# Determine container keyword filter based on container_runtime
@@ -385,8 +375,8 @@ jobs:
385375
"local-invoke")
386376
pytest -vv --reruns 3 tests/integration/local/invoke tests/integration/local/generate_event --json-report --json-report-file=TEST_REPORT-integration-local-invoke-${{ matrix.container_runtime }}.json
387377
;;
388-
"local-start")
389-
pytest -vv --reruns 3 tests/integration/local/start_api --ignore tests/integration/local/start_api/test_start_api_with_terraform_application.py --json-report --json-report-file=TEST_REPORT-integration-local-start-${{ matrix.container_runtime }}.json
378+
"local-start1")
379+
pytest -vv --reruns 3 tests/integration/local/start_api --ignore tests/integration/local/start_api/test_start_api_with_terraform_application.py --json-report --json-report-file=TEST_REPORT-integration-local-start1-${{ matrix.container_runtime }}.json
390380
;;
391381
"local-start2")
392382
pytest -vv --reruns 3 tests/integration/local/start_lambda tests/integration/local/start_api/test_start_api_with_terraform_application.py --json-report --json-report-file=TEST_REPORT-integration-local-start2-${{ matrix.container_runtime }}.json

0 commit comments

Comments
 (0)