Skip to content

Commit 6c3b664

Browse files
authored
ci: retire GitHub-Action Slack notifier for new issues and PRs (#9065)
Removes the rtCamp/action-slack-notify pings: - Deletes .github/workflows/notify-slack.yml (issue-opened notifier). - Drops the "Send Slack Notification for External PR" step from pr-labeler.yml; the labeler still applies pr/internal vs pr/external + stage/needs-triage labels as before. Slack notifications for new aws-sam-cli issues and PRs are now sent by the team's GitHub-App-backed notifier (aws-sam-tooling-bot), which covers all of the team's owned repositories from a single backend rather than per-repo workflows. Retiring the workflow-based path here removes the duplicate posts and the long-lived SLACK_WEBHOOK_URL secret dependency on this repo's behalf.
1 parent c4bc8a2 commit 6c3b664

2 files changed

Lines changed: 1 addition & 34 deletions

File tree

.github/workflows/notify-slack.yml

Lines changed: 0 additions & 21 deletions
This file was deleted.

.github/workflows/pr-labeler.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ jobs:
2020
runs-on: ubuntu-latest
2121
steps:
2222
- name: Apply internal/external label
23-
id: label_step
2423
uses: actions/github-script@v9
2524
with:
2625
github-token: ${{secrets.GITHUB_TOKEN}}
@@ -29,7 +28,7 @@ jobs:
2928
'aws-sam-cli-bot',
3029
'seshubaws', 'valerena',
3130
'Vandita2020', 'roger-zhangg',
32-
'vicheey', 'bnusunny', 'tobixlea',
31+
'vicheey', 'bnusunny', 'tobixlea',
3332
'reedham-aws', 'licjun', 'dependabot[bot]'
3433
];
3534
if (maintainers.includes(context.payload.sender.login)) {
@@ -39,22 +38,11 @@ jobs:
3938
repo: context.repo.repo,
4039
labels: ['pr/internal']
4140
});
42-
core.setOutput("external", "false");
4341
} else {
4442
await github.rest.issues.addLabels({
4543
issue_number: context.issue.number,
4644
owner: context.repo.owner,
4745
repo: context.repo.repo,
4846
labels: ['pr/external', 'stage/needs-triage']
4947
});
50-
core.setOutput("external", "true");
5148
}
52-
- name: Send Slack Notification for External PR
53-
if: steps.label_step.outputs.external == 'true'
54-
uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2
55-
env:
56-
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }}
57-
SLACK_TITLE: 'PR Created: ${{ github.event.pull_request.title }} by ${{ github.event.pull_request.user.login }}'
58-
SLACK_FOOTER: ''
59-
MSG_MINIMAL: true
60-
SLACK_MESSAGE: '${{ github.event.pull_request.html_url }}'

0 commit comments

Comments
 (0)