Commit 7ac37e0
committed
docs(designs): add merge_group trigger to semver-gate workflow
Per review on PR #9057: the workflow as proposed only declared
on.pull_request, but this repo uses GitHub's merge queue (see
build.yml's existing merge_group trigger). When a PR enters the
queue, GitHub dispatches a merge_group event against an ephemeral
ref, not pull_request. A required check that only listens on
pull_request never reports a status on the merge_group event, so
the merge queue treats it as missing/pending and blocks the merge —
the same skipped-but-required failure mode the path-filter pitfall
was about, just under a different trigger.
Mirror build.yml: listen on both pull_request and merge_group with
the same branch filters. The check_semver_bump.py script's
self-gating (exit 0 when no expected.*.yaml changed) only helps
when the workflow runs at all; this fix makes it run.
Add a "resolve base ref" step because the two event types expose
the target branch differently: pull_request sets github.base_ref to
the bare branch name; merge_group leaves base_ref empty and exposes
the full ref at github.event.merge_group.base_ref (e.g.
"refs/heads/develop"), which we strip to match the pull_request
shape before passing to check_semver_bump.py.
Document both flavors of the pitfall (path-filter and
single-trigger) in the design's "skipped but required" callout so
future maintainers see why we chose this trigger configuration.1 parent fd5e38c commit 7ac37e0
1 file changed
Lines changed: 31 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
342 | 343 | | |
343 | 344 | | |
344 | 345 | | |
345 | 346 | | |
346 | 347 | | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
347 | 351 | | |
348 | 352 | | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
355 | 375 | | |
356 | 376 | | |
357 | 377 | | |
| |||
0 commit comments